Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Harden telemetry code against invalid arguments #321

Merged
merged 4 commits into from
Nov 5, 2024
Merged

feat: Harden telemetry code against invalid arguments #321

merged 4 commits into from
Nov 5, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 4, 2024 •
edited
Loading

No description provided.

@krlmlr krlmlr enabled auto-merge November 4, 2024 17:25
@krlmlr krlmlr added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0e68796 is merged into main:

  • ✔️001_tpch_01: 26.2ms -> 26.2ms [-4.35%, +3.86%]
  • ✔️001_tpch_02: 135ms -> 133ms [-2.3%, 0%]
  • ✔️001_tpch_03: 69ms -> 68.8ms [-1.96%, +1.13%]
  • ✔️001_tpch_04: 24.9ms -> 24.5ms [-3.66%, +0.23%]
  • ✔️001_tpch_05: 126ms -> 126ms [-1.42%, +1.31%]
  • ✔️001_tpch_06: 15.7ms -> 15.6ms [-3.15%, +2.38%]
  • 🚀001_tpch_07: 146ms -> 143ms [-3.45%, -0.41%]
  • 🚀001_tpch_08: 163ms -> 161ms [-2.43%, -0.31%]
  • 🚀001_tpch_09: 134ms -> 132ms [-2.17%, -0.01%]
  • ✔️001_tpch_10: 79.7ms -> 78ms [-4.49%, +0.21%]
  • ✔️001_tpch_11: 64ms -> 63.3ms [-2.81%, +0.89%]
  • 🚀001_tpch_12: 56.1ms -> 28.5ms [-49.99%, -48.42%]
  • 🚀001_tpch_13: 20ms -> 19.4ms [-4.57%, -0.77%]
  • ✔️001_tpch_14: 21.3ms -> 21.3ms [-2.28%, +2.41%]
  • ✔️001_tpch_15: 62.5ms -> 62.1ms [-2.63%, +1.21%]
  • ✔️001_tpch_16: 65.1ms -> 65.3ms [-1.89%, +2.46%]
  • ✔️001_tpch_17: 27.3ms -> 27.5ms [-2.28%, +3.48%]
  • ✔️001_tpch_18: 23.4ms -> 23.2ms [-2.57%, +0.89%]
  • ✔️001_tpch_19: 125ms -> 126ms [-0.42%, +1.65%]
  • 🚀001_tpch_20: 81.6ms -> 79.2ms [-5.05%, -0.81%]
  • ✔️001_tpch_21: 186ms -> 184ms [-2.19%, +0.72%]
  • ✔️001_tpch_22: 132ms -> 133ms [-2.84%, +5.28%]
  • ✔️010_tpch_01: 84.3ms -> 83.7ms [-7.57%, +6.26%]
  • ✔️010_tpch_02: 75.6ms -> 73.3ms [-6.3%, +0.32%]
  • ✔️010_tpch_03: 67.7ms -> 68.1ms [-3.61%, +4.91%]
  • ✔️010_tpch_04: 49.9ms -> 49.4ms [-3.16%, +1.19%]
  • 🚀010_tpch_05: 98ms -> 94.1ms [-7.69%, -0.11%]
  • ✔️010_tpch_06: 35.5ms -> 37.2ms [-1.97%, +11.52%]
  • ✔️010_tpch_07: 117ms -> 116ms [-2.75%, +0.49%]
  • ✔️010_tpch_08: 137ms -> 136ms [-2.71%, +1.53%]
  • ✔️010_tpch_09: 120ms -> 119ms [-3.1%, +1.45%]
  • 🚀010_tpch_10: 87.8ms -> 85.4ms [-4.59%, -0.69%]
  • ✔️010_tpch_11: 40.2ms -> 40.3ms [-3.92%, +4.01%]
  • ✔️010_tpch_12: 64.8ms -> 63.6ms [-6.27%, +2.72%]
  • ✔️010_tpch_13: 53.3ms -> 52.7ms [-3.35%, +1.07%]
  • ✔️010_tpch_14: 42.5ms -> 42.3ms [-2.01%, +1.41%]
  • ✔️010_tpch_15: 60.6ms -> 59.6ms [-8.32%, +5.05%]
  • ✔️010_tpch_16: 47.1ms -> 46ms [-4.77%, +0.19%]
  • ✔️010_tpch_17: 59.3ms -> 57.2ms [-7.6%, +0.75%]
  • ✔️010_tpch_18: 56ms -> 55.4ms [-8.39%, +6.11%]
  • ✔️010_tpch_19: 124ms -> 123ms [-1.25%, +0.94%]
  • ✔️010_tpch_20: 78.1ms -> 77.8ms [-6.7%, +5.95%]
  • ✔️010_tpch_21: 431ms -> 436ms [-0.21%, +2.94%]
  • ✔️010_tpch_22: 81.4ms -> 81ms [-2.8%, +1.83%]
  • ✔️100_tpch_01: 1.2s -> 1.21s [-3.52%, +5.84%]
  • ✔️100_tpch_02: 122ms -> 127ms [-10.76%, +18.89%]
  • ✔️100_tpch_03: 1.06s -> 1.06s [-3.39%, +3.55%]
  • ✔️100_tpch_04: 1.08s -> 1.08s [-3.11%, +2.38%]
  • ✔️100_tpch_05: 1.22s -> 1.22s [-2.6%, +2.48%]
  • ✔️100_tpch_06: 1s -> 1.01s [-4.83%, +7.03%]
  • ✔️100_tpch_07: 1.14s -> 1.12s [-3.47%, +1.24%]
  • ✔️100_tpch_08: 1.14s -> 1.13s [-3.32%, +2.26%]
  • ✔️100_tpch_09: 1.24s -> 1.22s [-4.69%, +1.86%]
  • ✔️100_tpch_10: 1.12s -> 1.1s [-5.22%, +1.41%]
  • ✔️100_tpch_11: 80.5ms -> 81.3ms [-5.21%, +7.17%]
  • ✔️100_tpch_12: 1.08s -> 1.08s [-1.3%, +1.51%]
  • ✔️100_tpch_13: 304ms -> 319ms [-4.84%, +14.32%]
  • ✔️100_tpch_14: 996ms -> 1s [-2.72%, +3.89%]
  • ✔️100_tpch_15: 1.09s -> 1.08s [-2.2%, +0.2%]
  • ✔️100_tpch_16: 123ms -> 129ms [-10.47%, +20.41%]
  • ✔️100_tpch_17: 1.06s -> 1.05s [-2.72%, +1.71%]
  • ✔️100_tpch_18: 1.08s -> 1.09s [-1.78%, +2.41%]
  • ✔️100_tpch_19: 1.16s -> 1.19s [-0.73%, +5.1%]
  • ✔️100_tpch_20: 1.07s -> 1.09s [-2.84%, +5.28%]
  • ✔️100_tpch_21: 2.25s -> 2.21s [-6.56%, +3.41%]
  • ✔️100_tpch_22: 174ms -> 176ms [-6.32%, +8.17%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@krlmlr krlmlr enabled auto-merge November 4, 2024 21:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 97b94a7 is merged into main:

  • ✔️001_tpch_01: 24.9ms -> 24.4ms [-6.18%, +2.02%]
  • ✔️001_tpch_02: 126ms -> 125ms [-2.2%, +0.19%]
  • 🚀001_tpch_03: 66ms -> 64.9ms [-2.95%, -0.4%]
  • ✔️001_tpch_04: 24.1ms -> 23.9ms [-2.25%, +0.1%]
  • 🚀001_tpch_05: 121ms -> 118ms [-3.89%, -1.41%]
  • ✔️001_tpch_06: 15.1ms -> 14.9ms [-2.85%, +0.68%]
  • ✔️001_tpch_07: 138ms -> 138ms [-1.35%, +1.58%]
  • 🚀001_tpch_08: 160ms -> 155ms [-4.33%, -2.27%]
  • ✔️001_tpch_09: 133ms -> 131ms [-3.35%, +0.67%]
  • ✔️001_tpch_10: 76ms -> 75.5ms [-1.86%, +0.46%]
  • 🚀001_tpch_11: 63.7ms -> 62.5ms [-3.17%, -0.43%]
  • 🚀001_tpch_12: 58.1ms -> 28.6ms [-51.96%, -49.67%]
  • ✔️001_tpch_13: 20ms -> 19.7ms [-3.06%, +0.25%]
  • ✔️001_tpch_14: 21.5ms -> 21ms [-5.23%, +1.14%]
  • ✔️001_tpch_15: 63.4ms -> 62.6ms [-2.77%, +0.37%]
  • ✔️001_tpch_16: 64.9ms -> 64.3ms [-2.33%, +0.36%]
  • 🚀001_tpch_17: 27.3ms -> 26.9ms [-2.14%, -0.99%]
  • 🚀001_tpch_18: 23.4ms -> 22.8ms [-4.6%, -0.12%]
  • ✔️001_tpch_19: 128ms -> 128ms [-1.51%, +0.87%]
  • ✔️001_tpch_20: 77.7ms -> 77ms [-2.1%, +0.32%]
  • ✔️001_tpch_21: 173ms -> 174ms [-1.03%, +1.51%]
  • ✔️001_tpch_22: 125ms -> 124ms [-2.09%, +0.5%]
  • ✔️010_tpch_01: 84.3ms -> 83.5ms [-4.98%, +3.06%]
  • ✔️010_tpch_02: 73.1ms -> 71.5ms [-4.8%, +0.37%]
  • ✔️010_tpch_03: 67ms -> 66.1ms [-4.19%, +1.67%]
  • ✔️010_tpch_04: 50.9ms -> 49.5ms [-8.91%, +3.45%]
  • 🚀010_tpch_05: 96.6ms -> 94.4ms [-4.1%, -0.46%]
  • ✔️010_tpch_06: 37.9ms -> 36.1ms [-11.77%, +2.51%]
  • 🚀010_tpch_07: 115ms -> 114ms [-2.2%, -0.21%]
  • 🚀010_tpch_08: 138ms -> 133ms [-6.06%, -0.92%]
  • ✔️010_tpch_09: 118ms -> 118ms [-2.46%, +1.19%]
  • 🚀010_tpch_10: 85.9ms -> 84.7ms [-2.58%, -0.08%]
  • ✔️010_tpch_11: 41.1ms -> 39.4ms [-14.47%, +5.89%]
  • ✔️010_tpch_12: 62.4ms -> 62.9ms [-0.79%, +2.29%]
  • ✔️010_tpch_13: 52.8ms -> 54ms [-4.43%, +8.86%]
  • ✔️010_tpch_14: 41.8ms -> 41.9ms [-1.23%, +1.72%]
  • ✔️010_tpch_15: 58.1ms -> 60.6ms [-2.96%, +11.79%]
  • 🚀010_tpch_16: 45.8ms -> 44.2ms [-6.05%, -0.94%]
  • ✔️010_tpch_17: 55.3ms -> 56ms [-0.97%, +3.61%]
  • ✔️010_tpch_18: 59.2ms -> 55.4ms [-13.44%, +0.76%]
  • ✔️010_tpch_19: 124ms -> 123ms [-2.26%, +0.45%]
  • 🚀010_tpch_20: 75.2ms -> 72.6ms [-6.59%, -0.18%]
  • ✔️010_tpch_21: 427ms -> 425ms [-1.82%, +0.98%]
  • ✔️010_tpch_22: 79.4ms -> 77.1ms [-7.71%, +2.04%]
  • ✔️100_tpch_01: 1.16s -> 1.17s [-2.09%, +2.5%]
  • ✔️100_tpch_02: 122ms -> 120ms [-4.85%, +1.89%]
  • ✔️100_tpch_03: 1.07s -> 1.06s [-4.18%, +3.1%]
  • ✔️100_tpch_04: 1.04s -> 1.04s [-2.62%, +3.36%]
  • ✔️100_tpch_05: 1.16s -> 1.14s [-4.92%, +1.88%]
  • ✔️100_tpch_06: 985ms -> 989ms [-2.11%, +2.96%]
  • ✔️100_tpch_07: 1.12s -> 1.13s [-1.79%, +3.4%]
  • ✔️100_tpch_08: 1.14s -> 1.16s [-2.26%, +4.23%]
  • ✔️100_tpch_09: 1.23s -> 1.23s [-1.52%, +2.34%]
  • ✔️100_tpch_10: 1.11s -> 1.1s [-3.24%, +2.7%]
  • ✔️100_tpch_11: 87.5ms -> 82.7ms [-12.17%, +1.09%]
  • ✔️100_tpch_12: 1.09s -> 1.11s [-0.36%, +4.01%]
  • ✔️100_tpch_13: 329ms -> 323ms [-12.49%, +8.87%]
  • ✔️100_tpch_14: 993ms -> 1.01s [-0.56%, +3.44%]
  • ✔️100_tpch_15: 1.08s -> 1.09s [-0.18%, +3.13%]
  • ✔️100_tpch_16: 122ms -> 124ms [-2.16%, +4.05%]
  • ✔️100_tpch_17: 1.06s -> 1.04s [-3.13%, +0.27%]
  • ✔️100_tpch_18: 1.07s -> 1.08s [-1.74%, +3.4%]
  • ✔️100_tpch_19: 1.16s -> 1.18s [-0.81%, +3.45%]
  • ✔️100_tpch_20: 1.06s -> 1.08s [-0.26%, +4.31%]
  • ✔️100_tpch_21: 2.19s -> 2.18s [-3.47%, +2.4%]
  • ✔️100_tpch_22: 169ms -> 171ms [-3.5%, +4.78%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 2bfa487 Nov 5, 2024
18 checks passed
@krlmlr krlmlr deleted the f-try-list branch November 5, 2024 07:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 5c378ce is merged into main:

  • ✔️001_tpch_01: 25.6ms -> 25.2ms [-5.52%, +2.36%]
  • ✔️001_tpch_02: 131ms -> 130ms [-1.7%, +0.86%]
  • 🚀001_tpch_03: 70.9ms -> 70ms [-2.45%, -0.05%]
  • 🚀001_tpch_04: 25.4ms -> 24.9ms [-2.85%, -0.75%]
  • ✔️001_tpch_05: 125ms -> 125ms [-1.63%, +0.07%]
  • ✔️001_tpch_06: 16.4ms -> 16.2ms [-4.57%, +2.34%]
  • 🚀001_tpch_07: 146ms -> 143ms [-3.08%, -1.12%]
  • 🚀001_tpch_08: 165ms -> 163ms [-1.95%, -0.5%]
  • 🚀001_tpch_09: 135ms -> 133ms [-3.06%, -0.52%]
  • 🚀001_tpch_10: 147ms -> 78.2ms [-47.46%, -45.94%]
  • ✔️001_tpch_11: 66.4ms -> 65.9ms [-1.86%, +0.57%]
  • 🚀001_tpch_12: 61.1ms -> 60.2ms [-2.65%, -0.18%]
  • 🚀001_tpch_13: 21.6ms -> 20.9ms [-6.26%, -0.13%]
  • ✔️001_tpch_14: 22.4ms -> 22.3ms [-2.97%, +2.6%]
  • ✔️001_tpch_15: 66.3ms -> 65.5ms [-2.59%, +0.06%]
  • ✔️001_tpch_16: 68ms -> 67ms [-2.93%, +0.06%]
  • 🚀001_tpch_17: 28.7ms -> 28ms [-3.82%, -0.84%]
  • ✔️001_tpch_18: 24.5ms -> 24.2ms [-3.87%, +1.66%]
  • ✔️001_tpch_19: 133ms -> 133ms [-0.97%, +0.8%]
  • ✔️001_tpch_20: 82.2ms -> 82.4ms [-1.07%, +1.6%]
  • 🚀001_tpch_21: 181ms -> 179ms [-2.1%, -0.51%]
  • ✔️001_tpch_22: 129ms -> 130ms [-0.53%, +1.09%]
  • ✔️010_tpch_01: 84.3ms -> 83ms [-5.17%, +2.2%]
  • 🚀010_tpch_02: 74.5ms -> 72.5ms [-4.16%, -1.31%]
  • ✔️010_tpch_03: 68.2ms -> 67.6ms [-4.55%, +3.01%]
  • ✔️010_tpch_04: 50.3ms -> 49.9ms [-3.24%, +1.54%]
  • 🚀010_tpch_05: 100ms -> 96.9ms [-6.49%, -0.1%]
  • ✔️010_tpch_06: 36.5ms -> 35.4ms [-6.71%, +0.9%]
  • 🚀010_tpch_07: 119ms -> 114ms [-6.99%, -0.71%]
  • 🚀010_tpch_08: 137ms -> 135ms [-2.88%, -0.74%]
  • ✔️010_tpch_09: 121ms -> 119ms [-3.66%, +0.6%]
  • ✔️010_tpch_10: 88.1ms -> 86.2ms [-5.78%, +1.36%]
  • ✔️010_tpch_11: 40ms -> 39.8ms [-2.85%, +1.92%]
  • ✔️010_tpch_12: 63.3ms -> 63.1ms [-1.19%, +0.63%]
  • 🚀010_tpch_13: 54.4ms -> 52.8ms [-6.07%, -0.12%]
  • ✔️010_tpch_14: 42.8ms -> 42.4ms [-1.92%, +0.45%]
  • ✔️010_tpch_15: 60.4ms -> 59.2ms [-8.97%, +4.82%]
  • ✔️010_tpch_16: 46.4ms -> 45.7ms [-4.03%, +1.06%]
  • ✔️010_tpch_17: 57ms -> 56.2ms [-3.88%, +1.04%]
  • ✔️010_tpch_18: 55.4ms -> 56.7ms [-5.24%, +9.97%]
  • ✔️010_tpch_19: 125ms -> 124ms [-1.81%, +1.53%]
  • ✔️010_tpch_20: 75.3ms -> 75.1ms [-3.82%, +3.24%]
  • ✔️010_tpch_21: 423ms -> 423ms [-1.19%, +1.46%]
  • 🚀010_tpch_22: 80.2ms -> 78.5ms [-4.3%, -0.06%]
  • ✔️100_tpch_01: 1.16s -> 1.18s [-2.42%, +5.42%]
  • ✔️100_tpch_02: 126ms -> 121ms [-11.47%, +3.81%]
  • ✔️100_tpch_03: 1.06s -> 1.09s [-1.01%, +6.07%]
  • 🚀100_tpch_04: 1.05s -> 1.03s [-3.18%, -0.32%]
  • ✔️100_tpch_05: 1.15s -> 1.15s [-1.74%, +2.27%]
  • ✔️100_tpch_06: 978ms -> 987ms [-1.33%, +3.36%]
  • ✔️100_tpch_07: 1.12s -> 1.11s [-3.14%, +1.45%]
  • ✔️100_tpch_08: 1.16s -> 1.13s [-4.88%, +0.58%]
  • ✔️100_tpch_09: 1.22s -> 1.22s [-2.29%, +2.17%]
  • ✔️100_tpch_10: 1.11s -> 1.1s [-3.99%, +2.34%]
  • ✔️100_tpch_11: 89.2ms -> 81.5ms [-24.86%, +7.48%]
  • ✔️100_tpch_12: 1.09s -> 1.08s [-4.79%, +2.29%]
  • ✔️100_tpch_13: 333ms -> 333ms [-5.42%, +5.88%]
  • ✔️100_tpch_14: 1s -> 1.01s [-1.5%, +4.06%]
  • ✔️100_tpch_15: 1.1s -> 1.09s [-3.03%, +1.58%]
  • ✔️100_tpch_16: 125ms -> 129ms [-8.05%, +14.78%]
  • ❗🐌100_tpch_17: 1.04s -> 1.06s [+0.35%, +3.44%]
  • ❗🐌100_tpch_18: 1.07s -> 1.08s [+0.14%, +2.84%]
  • ✔️100_tpch_19: 1.19s -> 1.19s [-3.76%, +3.27%]
  • ✔️100_tpch_20: 1.05s -> 1.06s [-0.06%, +1.41%]
  • ✔️100_tpch_21: 2.22s -> 2.25s [-2.75%, +5.69%]
  • ✔️100_tpch_22: 175ms -> 188ms [-7.33%, +21.91%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krlmlr