Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New df_to_parquet() to write to Parquet, new convenience df_from_csv(), duckdb_df_from_csv(), df_from_parquet() and duckdb_df_from_parquet() #128

Merged
merged 12 commits into from
Mar 17, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 17, 2024

Closes #87. Closes #89. Closes #96.

@krlmlr krlmlr changed the title Move source feat: New df_to_parquet() to write to Parquet, new convenience df_from_csv(), duckdb_df_from_csv(), df_from_parquet() and duckdb_df_from_parquet() Mar 17, 2024
@eitsupi
Copy link

eitsupi commented Mar 17, 2024

How about use _read_ and _write_ instead of _from_ and _to_?

@krlmlr
Copy link
Member Author

krlmlr commented Mar 17, 2024

df_read_file() ? It's not strictly reading -- the reading only happens during materialization. Keeping it now as is, we can revisit later.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 9.75%. Comparing base (9e952d7) to head (eb9e6d9).

❗ Current head eb9e6d9 differs from pull request most recent head e97b432. Consider uploading reports for the commit e97b432 to get more accurate results

Files Patch % Lines
R/io-csv.R 50.00% 2 Missing ⚠️
R/io-parquet.R 71.42% 2 Missing ⚠️
R/io.R 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #128      +/-   ##
========================================
+ Coverage   9.66%   9.75%   +0.09%     
========================================
  Files        127     129       +2     
  Lines      22633   22646      +13     
========================================
+ Hits        2187    2209      +22     
+ Misses     20446   20437       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krlmlr krlmlr merged commit 06328b4 into main Mar 17, 2024
9 checks passed
@krlmlr krlmlr deleted the f-file branch March 17, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants