chore: Add calls for telemetry #107
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
========================================
+ Coverage 9.10% 9.27% +0.17%
========================================
Files 127 128 +1
Lines 22401 22448 +47
========================================
+ Hits 2040 2083 +43
- Misses 20361 20365 +4 ☔ View full report in Codecov by Sentry. |
| ! filter: {"message":"Error in filter","name":"filter","x":{"...1":"integer","...2":"integer"},"args":{"dots":{"1":"...1 > \"Don't know how to scrub numeric\""},"by":"...2","preserve":false}} | ||
|
|
||
| --- | ||
|
|
||
| Code | ||
| tibble(a = 1:3, b = 4:6) %>% as_duckplyr_df() %>% filter(a > 1, .preserve = TRUE) | ||
| Condition | ||
| Error in `rel_try()`: | ||
| ! filter: {"message":"Error in filter","name":"filter","x":{"...1":"integer","...2":"integer"},"args":{"dots":{"1":"...1 > \"Don't know how to scrub numeric\""},"by":"\"Don't know how to scrub NULL\"","preserve":true}} |
There was a problem hiding this comment.
Just checking, you want to see "dont know how to scrub numeric" in these cases?
There was a problem hiding this comment.
Good question. I guess it's fine to use "<character>" for strings, and to pass through other types?
For #102.
@hadley @DavisVaughan: Proposing data for the telemetry. Have I missed anything?