Add connect-info command #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuanyu66
requested changes
Jan 18, 2023
xuanyu66
reviewed
Jan 18, 2023
shiyuhang0
previously approved these changes
Jan 30, 2023
|
Don't forget to update the cli doc on the pingcap official website |
|
@shiyuhang0 Thanks for your review. I will add this command to the doc when it is merged. |
xuanyu66
previously approved these changes
Feb 1, 2023
zhangyangyu
reviewed
Feb 15, 2023
zhangyangyu
reviewed
Feb 15, 2023
zhangyangyu
reviewed
Feb 15, 2023
This reverts commit c494c2c.
# Conflicts: # internal/cli/cluster/list.go # internal/cli/dataimport/list.go # internal/cli/project/list.go # internal/service/cloud/api_client.go
zhangyangyu
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
connect-infocommand to get the connection string.