Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #13

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Update dependencies #13

merged 7 commits into from
Jan 15, 2025

Conversation

enjikaka
Copy link
Contributor

  • Update dependencies
  • Fix some issues from the new eslint-tidal-config version

@enjikaka enjikaka requested a review from Copilot January 13, 2025 13:09
@enjikaka enjikaka self-assigned this Jan 13, 2025
Copilot
Copilot AI reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/client/js/message-bridge.js:51

  • Removing the catch variable 'e' makes it harder to diagnose issues if JSON parsing fails. Consider keeping 'e' for potential future use.
catch {

@enjikaka enjikaka requested a review from osmestad January 14, 2025 10:31
osmestad
osmestad reviewed Jan 14, 2025
View reviewed changes
package.json Outdated
"typescript": "^5.7.3"
},
"dependencies": {
"chai": "^5.1.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chai should probably be a devDep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@enjikaka enjikaka merged commit 9207701 into main Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@osmestad osmestad osmestad approved these changes

Assignees

@enjikaka enjikaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enjikaka @osmestad