Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

[Swap] Show address type for recipient #1857

Merged
merged 4 commits into from
Oct 17, 2021

Conversation

gromxyz
Copy link
Contributor

@gromxyz gromxyz commented Oct 14, 2021

Closes #1846

Screen.Recording.2021-10-14.at.12.25.59.mov

@gromxyz gromxyz requested a review from veado October 14, 2021 10:27
@gromxyz gromxyz self-assigned this Oct 14, 2021
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in DM: Pls try to implement a more reactive way to change the label by entering/changing the address in the input (but not after clicking save icon).

@veado
Copy link
Collaborator

veado commented Oct 14, 2021

After clicking cancel button, wallettype has not been updated.

Example 1

  • After canceling changes, keystore should be shown
Peek.2021-10-14.16-44.mp4

Example 2

  • After entering Ledger address, but clicking cancel button, keystore should be shown
Peek.2021-10-14.16-42.mp4

gromxyz and others added 2 commits October 14, 2021 19:20
- Fix race condition in EditableAddress `inputOnKeyUpHandler`
- Tweak tests + styles
@veado veado merged commit 97d8a95 into develop Oct 17, 2021
@veado veado deleted the issue-1846/show-address-type-for-recipient branch October 17, 2021 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Swap] Show address type for recipient
2 participants