Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Title Styles Changed in 2023.6.0 #587

Closed
4 tasks done
shbatm opened this issue Jun 6, 2023 · 24 comments
Closed
4 tasks done

Popup Title Styles Changed in 2023.6.0 #587

shbatm opened this issue Jun 6, 2023 · 24 comments

Comments

@shbatm
Copy link

shbatm commented Jun 6, 2023

My Home Assistant version: 2023.6.0b4

What I am doing:
Showing a popup with browser_mod.popup in several locations in my dashboard.
image

It looks like this change in the frontend is to blame for the restructure, removing the old main-title class:
home-assistant/frontend#16485

What I expected to happen:
Styled the same as a more-info dialog

What happened instead:
Title text is showing as normal font on next line

Minimal steps to reproduce:
Use a popup service call in 2023.6.0b3+

      - type: custom:mushroom-cover-card
        entity: cover.island_shades
        hold_action:
          action: fire-dom-event
          haptic: success
          browser_mod:
            service: browser_mod.popup
            data:
              title: Island Shades
              content:
                type: vertical-stack
                cards:
                  - type: custom:mushroom-cover-card
                    entity: cover.island_shades
                    name: All Island Shades

Error messages from the browser console:

// Select everything from the browser console and copy it

// Paste it here

By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:

  • Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).

  • Have made sure I am using the latest version of the plugin.

  • Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.

  • Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.

@thornygravy
Copy link

same here

@marcis92
Copy link

marcis92 commented Jun 8, 2023

+1

5 similar comments
@Xitro01
Copy link

Xitro01 commented Jun 8, 2023

+1

@amaciuc
Copy link

amaciuc commented Jun 8, 2023

+1

@jfeltges
Copy link

jfeltges commented Jun 8, 2023

+1

@melnikovRV
Copy link

+1

@limitless00net
Copy link

+1

bendikrb added a commit to bendikrb/hass-browser_mod that referenced this issue Jun 8, 2023
bendikrb added a commit to bendikrb/hass-browser_mod that referenced this issue Jun 8, 2023
@smartqasa
Copy link

Same here

@Kzibi
Copy link

Kzibi commented Jun 10, 2023

+1

1 similar comment
@KGS501
Copy link

KGS501 commented Jun 11, 2023

+1

@0546timm
Copy link

Same issue here, anybody got a workaround for it?

@shbatm
Copy link
Author

shbatm commented Jun 13, 2023

There is an open PR linked above, which you can use to manually update your local copy.

@0546timm
Copy link

Im going to sound like a moron, but what do you mean with open PR?

@shbatm
Copy link
Author

shbatm commented Jun 13, 2023

A Pull Request (changes waiting to be reviewed and included).

https://github.com/thomasloven/hass-browser_mod/pull/588/files

The link above shows the changes that need to be made to fix this.

@Kzibi
Copy link

Kzibi commented Jun 14, 2023

workaround : don't use title - only content
popup

@0546timm
Copy link

workaround : don't use title - only content popup

I like the inituativity. But that's not a workaround, that's just using another feature. It does not serve the same purpose.

@deluxestyle
Copy link

it seems there is not that much ongoing in this repository.

@smartqasa
Copy link

smartqasa commented Jun 19, 2023

it seems there is not that much ongoing in this repository.

... and yet it is probably one of the most important custom integrations with respect to Dashboards.

I mean no disrespect to the author. This is truly indispensable work. Perhaps one day it can be fully integrated into Dashboards as a feature.

@shbatm
Copy link
Author

shbatm commented Jun 19, 2023

it seems there is not that much ongoing in this repository.

Having been on the other side plenty of times--it's still all just volunteer work by a few individuals and life gets in the way, so I'm not in hurry.

If you want a "quick" fix:

  1. Go here: https://github.com/bendikrb/hass-browser_mod/tree/ha-dialog-fix/custom_components/browser_mod
  2. Download browser_mod.js and browser_mod_panel.js
  3. Replace the files in your /config/custom_components/browser_mod/ folder and delete any .gz files with the same names.
  4. Restart HA & clear your browser cache.

@pedolsky
Copy link

pedolsky commented Jun 20, 2023

After loading the that files, the services browser_mod.notification and browser_mod.popup don’t work anymore.

Ok, I'm dumb. Forgot to reload Browser ID.

@ThatTallGuy21
Copy link

I'm also having this same issue with the browser titles. Thankfully this is the only problem I've experienced since upgrading. I agree with others. Hopefully the concept of a browser popup can be core functionality to HA. In the meantime, I will have to wait patiently for a fix.

@thornygravy
Copy link

I'm also having this same issue with the browser titles. Thankfully this is the only problem I've experienced since upgrading. I agree with others. Hopefully the concept of a browser popup can be core functionality to HA. In the meantime, I will have to wait patiently for a fix.

I was nervous to do the fix manually, but it wasn't bad at all. Just putting that out there. Understandable if you want to wait for an update.

@smartqasa
Copy link

Mobile app has the same issue.

@dnestico
Copy link

dnestico commented Jul 4, 2023

Popup titles are still broken in 2023.6+

Because I still want the "X" close button I did this and it works for me for now:

title: ' '

Screenshot 2023-07-04 at 6 49 44 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests