Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add examples to the RTD #1772

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

kairoaraujo
Copy link
Contributor

This commit adds to the RTD the links references to source code
examples.
The examples are added to TUF ngclient Updater and Metadata.

Fixes #1716

Signed-off-by: Kairo de Araujo kdearaujo@vmware.com

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@coveralls
Copy link

coveralls commented Jan 14, 2022

Pull Request Test Coverage Report for Build 1712643674

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 98.676%

Totals Coverage Status
Change from base Build 1711894519: 1.0%
Covered Lines: 3937
Relevant Lines: 3960

💛 - Coveralls

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I think it would drastically improve discoverability of the examples, if they were referenced in the main menu too, e.g.:

  • API Reference
  • Installation
  • Usage examples
  • Instructions for Contributors

We can decide later if we create a dedicated examples landing/overview page on RTD, or in a README.md in the examples directory. For the time being the menu item could simply link to the examples directory in the repo. What do you think? Would you mind updating your PR to do this?

@kairoaraujo
Copy link
Contributor Author

We can decide later if we create a dedicated examples landing/overview page on RTD, or in a README.md in the examples directory. For the time being the menu item could simply link to the examples directory in the repo. What do you think? Would you mind updating your PR to do this?

I think it is good. My only concern was what you already mentioned, going out from the RTD without a landing page in the examples and being out of the RTD.
I don't mind updating the PR :)

Maybe as we don't have a README:

  • API Reference
  • Installation
  • Usage examples
    • client code example
    • repository code example
  • Instructions for Contributors

I am also ok with your suggestion.

@lukpueh
Copy link
Member

lukpueh commented Jan 18, 2022

I slightly lean towards not having sub-items in the menu in order to not convolute it. If you don't mind the effort, I'd prefer if you just added a barebones README.md to the examples folder with a similar paragraph that you already wrote for this PR.

This commit adds to the RTD the links references to source code
examples.
The examples are added to TUF ngclient Updater, Metadata and API
reference.
includes a seed for examples/README.md

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments!

# Usage examples

* [client](client_example)
* [repository](repo_example)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me to start with! 👍

@lukpueh lukpueh merged commit a9a4f9c into theupdateframework:develop Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the examples/client_example to RTD
3 participants