Design mode #1
Merged
Design mode #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a static boolean for application authors to check if their app is running in a visual designer or previewer. Tools can set this value when running the app in a designer or previewer context. Resolves xamarin#1731
These are the two supported APIs for design mode rendering, so to ensure the DesignMode boolean is set correctly for all existing releases of VS/VSMac, let's set it to true whenever something connects to the design mode rendering APIs.
4 tasks
therealjohn
added a commit
that referenced
this pull request
Feb 23, 2018
This reverts commit 8f8f31e.
|
Thanks, Alan. Strange, I didn't Revert this... |
therealjohn
pushed a commit
that referenced
this pull request
Feb 23, 2018
* Adds DesignMode class Provides a static boolean for application authors to check if their app is running in a visual designer or previewer. Tools can set this value when running the app in a designer or previewer context. Resolves xamarin#1731 * Enable design mode when we use the design mode APIs These are the two supported APIs for design mode rendering, so to ensure the DesignMode boolean is set correctly for all existing releases of VS/VSMac, let's set it to true whenever something connects to the design mode rendering APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I squashed up your original patches into one concise commit and then added the changes we need to make this work for anyone using the design mode rendering APIs.
This is rebased on tip of github.com/xamarin xamarin.forms master .