Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify queue in QueueCommand #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ojhaujjwal
Copy link

Currently, there's no way to specify custom queue name while dispatching a queue.
This is my attempt to do so.
I will write tests if the idea and the approach are liked.

@ojhaujjwal
Copy link
Author

I don't know why it is not working in php 5.5

@ojhaujjwal
Copy link
Author

what if I add onQueue(string $queueName) method. so, I could use something like:

$commandBus->dispatch(new QueueCommand(.....)->onQueue('emails'))

@rosstuck
Copy link
Member

@sagikazarmark Any thoughts here? This might need to be be a new interface rather extending the current one, since this would be a BC break for all current users.

Sidebar: perhaps we should have a chat on IRC sometime in the next few weeks about the future of the Bernard integration?

@ojhaujjwal
Copy link
Author

I don't understand the BC break scenario. Isn't the line Util::guessQueue enough for maintaining backwards compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants