Don't handle success callbacks after timeout (C* <= 2.1) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I never ran into this one so it may be handled a bit differently in 2.0 (or never had a "spotted" timeout in 2.1). Thanks ! |
michaelsembwever
pushed a commit
that referenced
this pull request
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important fix that we merged into Spotify's production Reaper in the beginning of the year (spotify/cassandra-reaper#148). The "Old repair API" (C* 1.2, 2.0, maybe 2.1 too) inexplicably returns
SESSION_SUCCESSwhen a repair session is aborted. That's what we do on timed out segments, and this led to a race condition where there's a chance that a segment that takes too long is flagged as "done" and never gets repaired.