Ec2MultiRegionAddressTranslator. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Translator for jmx connections
adejanovski
reviewed
Apr 28, 2017
| throws ReaperException { | ||
| ObjectName ssMbeanName; | ||
| ObjectName cmMbeanName; | ||
| JMXServiceURL jmxUrl; | ||
|
|
||
| if(addressTranslator != null) { | ||
| host = addressTranslator.translate(new InetSocketAddress(host, port)).getHostString(); |
There was a problem hiding this comment.
Introduce a new variable instead of reusing the parameter "host". 
There was a problem hiding this comment.
This is done by intention?
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
|
I assume currently master cannot be build due to the dependencies issue. @adejanovski |
|
Great job, merged ! |
michaelsembwever
pushed a commit
that referenced
this pull request
Jun 27, 2017
* Issue #90 Enabled the possibility to configure Ec2MultiregionAddressTranslator for jmx connections * Renamed setter * Entered dependency hell, increase guava version * Fix the cucumber version * Fix dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the possibility to configure Ec2MultiRegionAddressTranslator for jmx connections.
This is needed for Cassandra Cross AZ deployments where nodes have associated public IPs.
Actually the fix feels a bit hacky but we didn't find any better way without major efforts to make this work. If you have any idea for a better solution let us know.
We basically introduced new property
useAddressTranslatorwhich is false by default. In order not to instantiate a new instance of the translator each time we are passing one toJMXConnectionFactory.