Add dynamic discovery of seeds for clusters #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
adejanovski
commented
Mar 13, 2017
| Set<String> seedHostsFinal = seedHosts; | ||
| if (context.config.getEnableDynamicSeedList() | ||
| && liveNodes.isPresent()) { | ||
| seedHostsFinal = liveNodes.get().size()>0 |
There was a problem hiding this comment.
Use isEmpty() to check whether the collection is empty or not. 
adejanovski
commented
Mar 13, 2017
| @@ -253,5 +290,10 @@ public Response deleteCluster( | |||
| return Response.serverError().entity("delete failed for schedule with name \"" | |||
| + clusterName + "\"").build(); | |||
| } | |||
|
|
|||
| private Set<String> parseSeedHosts(String seedHost) { | |||
| return Arrays.stream(seedHost.split(",")).map(seed -> seed.trim()).collect(Collectors.toSet()); | |||
There was a problem hiding this comment.
Replace this lambda with a method reference.
nbozic-zz
approved these changes
Mar 13, 2017
|
no objections here. |
adejanovski
force-pushed
the
allow-multiple-seeds
branch
from
b15bc66 to
83ed42d
Compare
adejanovski
force-pushed
the
allow-multiple-seeds
branch
from
83ed42d to
9128024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Reaper has the data model to accept multiple seed nodes but doesn't use it, as it only takes a single seed as input.
This PR adds 2 things :
The list of nodes won't get updated afterwards though, and it is necessary to call
modifyClusterSeed(PUT /cluster/{clusterName}) in order to have a fresh list of nodes.The dynamic seed list is enabled by default and can be disabled in the yaml file.