Code improvements based on SonarQube analysis

[adejanovski]

No description provided.

[adejanovski]

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. CommonTools.java#L97: Remove this unused private "generateSegments" method.
2. RepairRunner.java#L295: Remove this unused private "repairSegment" method.
3. SegmentRunner.java#L321: Remove this unused private "repairHasSegmentRunning" method.

[michaelsembwever]

can we put 24 hours wait time between creation (or last comment) and merge? difficult for all to get a say otherwise.

my question around this is, and it may no longer be relevant to this specific PR, is what's the status of Spotify's original reaper repo? I see that they are still accepting commits?

[adejanovski]

@michaelsembwever : sure, that one was really about tidying the codebase based on SonarQube feedback, but you're right for the wait. On top of that I left a file that shouldn't be in there in the PR.

Based on what I see, the original Spotify repo is only merging internal PRs and there's no plan to reintegrate our fork for now.