-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt building debian, jar, and rpm packages using Dockerfiles #46
Conversation
thanks @joaquincasares . am using this today, timing couldn't have been better. |
docker/jar/Dockerfile
Outdated
# You can however run a command with sudo using --allow-root option | ||
# [ERROR] Command execution failed. | ||
RUN mvn clean package \ | ||
&& mvn clean package -Pbuild-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that information! That's good to know the UI doesn't need to be recompiled each time.
Would you mind taking a look at the cause of the sudo issue? It'd be nice to have a streamlined way to have potential contributors make changes and recompile the UI without having to manage about the entire build process.
I've implemented @adejanovski 's proposed changes, but needed to remove locking down rpm creation to the v.0.3.0 tag. The other two commands are still being tested, but this is the new rhel error:
|
@adejanovski for some reason the only record I have of your conversation exists only in email. 🤷
|
@joaquincasares Yes to just using fpm. I had set up the commands for that here: https://github.com/thelastpickle/cassandra-reaper/blob/master/Makefile. I'd prefer to rip out the debbuild stuff completely. |
@rustyrazorblade sounds good on using fpm. I'm not sure of what all can be removed for debuild. I will remove all text references to debuild in the README, but do I file another ticket to completely purge additional files? Or did debuild use all the |
@rustyrazorblade I've:
This should be the final commit, unless you two have any other recommendations. |
@adejanovski I've made your change for using cassandra.jar locally and also ran into your I'll work on that issue, as well as deprecating the packages/ directory in hopes of solely using target/. |
Hi @joaquincasares, could you tell us what is the status of that PR ? Thanks ! |
@@ -20,7 +20,7 @@ | |||
], | |||
"devDependencies": { | |||
"jquery": "~2.1.3", | |||
"startbootstrap-sb-admin-2": "git@github.com:BlackrockDigital/startbootstrap-sb-admin-2#v1.0.5", | |||
"startbootstrap-sb-admin-2": "https://github.com/BlackrockDigital/startbootstrap-sb-admin-2.git#v1.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #134 .
@@ -0,0 +1,17 @@ | |||
# editor files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip this file.
Not needed in #134 .
@@ -17,4 +17,7 @@ bin/ | |||
.settings/ | |||
.project | |||
build/ | |||
docker/production-reaper/*.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed.
Other lines are implemented in #134 .
@@ -1,13 +1,16 @@ | |||
# Using mvn: | |||
VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v '\[') | |||
VERSION := `mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v '\['` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #134 .
@@ -63,8 +63,8 @@ use the provided CLI tool in *bin/spreaper* to call the service. | |||
|
|||
Run the tool with *-h* or *--help* option to see usage instructions. | |||
|
|||
Notice that you can also build a Debian package from this project by using *debuild*, for example: | |||
`debuild -uc -us -b` | |||
Notice that you can also build Debian and RPM package from this project by using *Make*, for example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #134 .
@@ -12,7 +12,7 @@ The current version supports running Apache Cassandra cluster repairs in a segme | |||
opportunistically running multiple parallel repairs at the same time on different nodes | |||
within the cluster. Basic repair scheduling functionality is also supported. | |||
|
|||
Reaper comes with a GUI, which if you're running in local mode can be at http://localhost:8080/webui/ | |||
Reaper comes with a GUI, which if you're running in local mode can be at http://localhost:8080/webui/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug has already been fixed.
|
||
Reaper can also be accessed using the REST API exposed on port 8080, or using the command line tool `bin/spreaper` | ||
|
||
|
||
Docker Support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer relevant.
@@ -0,0 +1,45 @@ | |||
FROM ubuntu:16.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #134 .
@@ -0,0 +1,17 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #134 .
@@ -311,6 +311,7 @@ | |||
<workingDirectory>reaper_ui</workingDirectory> | |||
<arguments> | |||
<argument>install</argument> | |||
<argument>--allow-root</argument> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #134 .
@@ -0,0 +1,18 @@ | |||
FROM ubuntu:16.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated for #76.
@@ -0,0 +1,27 @@ | |||
FROM ubuntu:16.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed, just use the cassandra image instead.
@@ -0,0 +1,19 @@ | |||
FROM ubuntu:16.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated for #76.
@@ -0,0 +1,12 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated for #76.
@@ -21,6 +21,10 @@ jmxPorts: | |||
127.0.0.7: 7700 | |||
127.0.0.8: 7800 | |||
|
|||
#jmxAuth: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented via #135.
@@ -21,6 +21,10 @@ jmxPorts: | |||
127.0.0.7: 7700 | |||
127.0.0.8: 7800 | |||
|
|||
#jmxAuth: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented via #135.
@@ -21,6 +21,10 @@ jmxPorts: | |||
127.0.0.7: 7700 | |||
127.0.0.8: 7800 | |||
|
|||
#jmxAuth: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented via #135.
@@ -21,6 +21,10 @@ jmxPorts: | |||
127.0.0.7: 7700 | |||
127.0.0.8: 7800 | |||
|
|||
#jmxAuth: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented via #135.
@@ -21,6 +21,10 @@ jmxPorts: | |||
127.0.0.7: 7700 | |||
127.0.0.8: 7800 | |||
|
|||
#jmxAuth: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented via #135.
Pushing my Dockerfiles for review.
Experiencing these issues when installing the rpm package:
Experiencing this issue when attempting to build the jar while inside a Docker container:
The debian packages build successfully, even if they take a while to build.