Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to install and run reaper as a service #141

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

adejanovski
Copy link
Contributor

Remove unit tests from Makefile package phase (already done by the docker container)
Change package path to move from spotify to cassandra-reaper

Remove unit tests from Makefile package phase (already done by the docker container)
Change package path to move from spotify to cassandra-reaper
@adejanovski adejanovski merged commit 659ed92 into master Jul 19, 2017
@joaquincasares
Copy link
Contributor

@adejanovski just a heads up that the docker-build image doesn't run tests, but strictly uses the Makefile.

If we removed the tests from the Makefile, we'll need to add them to the docker-build's entrypoint:

https://github.com/thelastpickle/cassandra-reaper/blob/master/docker-build/docker-entrypoint.sh#L10-L13

I would personally opt for the tests in the Makefile, perhaps as a target, then add that target to the entrypoint.

@michaelsembwever michaelsembwever deleted the rpm-and-deb-fixes branch July 20, 2017 02:05
@adejanovski
Copy link
Contributor Author

@joaquincasares : when you call mvn clean package -Pbuild-ui in the docker-entrypoint.sh file, you run the unit tests. Then, the makefile calls mvn package which runs both the build and the unit tests for the second time.
Since the docker container builds the UI, which requires some dependencies that everyone might not have, it was fair to keep the build phase there.
I could've removed the tests from that build instead of the makefile's one, but it's no big deal anyway.

@joaquincasares
Copy link
Contributor

Ah, thanks for explaining. As long as the docker-build path still runs tests, all seems great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants