Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify Stargate nodes #1179

Merged
merged 9 commits into from
Mar 29, 2022

Conversation

jdonenine
Copy link
Contributor

@jdonenine jdonenine commented Mar 26, 2022

Add the ability to identify stargate nodes and distinguish them in the UI.

  • Updates the cluster/{name} endpoint response to include a new type property, will either be CASSANDRA or STARGATE
{
   "name":"stargate",
   "jmx_username":"",
   "jmx_password_is_set":false,
   "seed_hosts":[
      "127.0.0.2",
      "127.0.0.1"
   ],
   "repair_runs":[
      
   ],
   "repair_schedules":[
      
   ],
   "nodes_status":{
      "endpointStates":[
         {
            "sourceNode":"127.0.0.1",
            "endpoints":{
               "datacenter1":{
                  "rack1":[
                     {
                        "endpoint":"127.0.0.2",
                        "hostId":"bed76ae4-10c4-4f3b-af4b-e245011dbcc3",
                        "dc":"datacenter1",
                        "rack":"rack1",
                        "status":"Not available",
                        "severity":0.0,
                        "releaseVersion":"4.0.3",
                        "tokens":"",
                        "load":105498.0,
                        "type":"STARGATE"
                     },
                     {
                        "endpoint":"127.0.0.1",
                        "hostId":"8de68c6a-55e4-46ef-8be2-ccca39a9e9e1",
                        "dc":"datacenter1",
                        "rack":"rack1",
                        "status":"NORMAL - UP",
                        "severity":0.0,
                        "releaseVersion":"4.0.3",
                        "tokens":"18",
                        "load":93656.0,
                        "type":"CASSANDRA"
                     }
                  ]
               }
            },
            "totalLoad":199154.0,
            "endpointNames":[
               "127.0.0.2",
               "127.0.0.1"
            ]
         }
      ]
   }
}
  • Updated the cluster visualization to display Stargate nodes differently from Cassandra nodes - Stargate nodes now appear in clue with a note on their tooltip

image

  • Updated the node status visualization to hide details that will not be available for Stargate nodes, also added the (Stargate) label to the modal title as well as a display field called Node Type which will either be Cassandra or Stargate

image

  • Stargate nodes will also be excluded from Node select options when creating repairs/schedules.

Fixes #1145

…te nodes in selection options for creating repairs/schedules
…eaper into jdinoto-identify-stargate

* 'master' of https://github.com/thelastpickle/cassandra-reaper:
  No need to install bower in GHAs directly
  UI tooling update * Remove the external dependency on bower by moving it within the npm dependencies and scripts * Consolidates the UI dev/build process to be exclusively controlled through npm
  ninja-fix: Correct default keyspace value in Docker documentation
@jdonenine jdonenine marked this pull request as draft March 27, 2022 01:15
@jdonenine jdonenine marked this pull request as ready for review March 27, 2022 19:44
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks great @jdonenine, thanks!
You'll need to add a proper license header to the newly created node-utils.js file so that the build can go through.

@jdonenine
Copy link
Contributor Author

You'll need to add a proper license header to the newly created node-utils.js file so that the build can go through.

Ah the file header, gets me every time! Added in the last commit.

@jdonenine jdonenine requested a review from adejanovski March 29, 2022 02:58
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, Stargate nodes won't appear as down anymore 🤗
Thanks @jdonenine !

@adejanovski adejanovski merged commit c54491e into thelastpickle:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differente Stargate nodes within the UI
2 participants