Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to force create repair runs with conflicting units #1131

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

adejanovski
Copy link
Contributor

Similar to what was done with schedules, this PR builds on top of that previous work to allow force creation of repair runs.

@adejanovski adejanovski marked this pull request as draft October 19, 2021 09:30
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1131 (fd52d72) into master (f3f80a2) will decrease coverage by 0.18%.
The diff coverage is 58.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   74.08%   73.90%   -0.19%     
==========================================
  Files         110      110              
  Lines        9015     9035      +20     
  Branches      933      936       +3     
==========================================
- Hits         6679     6677       -2     
- Misses       1797     1807      +10     
- Partials      539      551      +12     
Impacted Files Coverage Δ
...sandrareaper/resources/RepairScheduleResource.java 58.36% <50.00%> (-0.91%) ⬇️
.../io/cassandrareaper/service/RepairUnitService.java 50.00% <60.00%> (-0.85%) ⬇️
...o/cassandrareaper/resources/RepairRunResource.java 50.00% <61.53%> (-1.59%) ⬇️
...assandrareaper/service/ClusterRepairScheduler.java 94.04% <100.00%> (ø)
...ain/java/io/cassandrareaper/jmx/SnapshotProxy.java 68.35% <0.00%> (-2.54%) ⬇️
...a/io/cassandrareaper/service/RepairRunService.java 73.05% <0.00%> (-1.42%) ⬇️
...assandrareaper/ReaperApplicationConfiguration.java 71.27% <0.00%> (-1.07%) ⬇️
.../io/cassandrareaper/resources/ClusterResource.java 69.31% <0.00%> (-1.06%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f80a2...fd52d72. Read the comment docs.

@adejanovski adejanovski force-pushed the alex/force-repair-run-conflict branch from 25f4505 to c84ff40 Compare October 19, 2021 12:59
@adejanovski adejanovski force-pushed the alex/force-repair-run-conflict branch from f60e559 to fd52d72 Compare October 19, 2021 17:13
@adejanovski adejanovski marked this pull request as ready for review October 20, 2021 06:48
Copy link
Member

@michaelsembwever michaelsembwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but only skimmed through it.

@adejanovski
Copy link
Contributor Author

I'll take it 😉

Thanks!

@adejanovski adejanovski merged commit aa7f290 into master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants