Fix the Base64-decoder failing if JWT_SECRET is not provided #1118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the JWT_SECRET is not specified, rest of the signing options are expected to be in Base64-format (which they're not). This modification requires only the JWT_SECRET to be in Base64-format, rest are not decoded anymore.
This should also fix #767 since the shortest Base64 string is 4 characters.
The Base64.getDecoder() is more strict and as such, this will test if those inputs are really Base64 or not (and current tests are enough to test this new behavior).