Skip to content

Commit

Permalink
Fix coordinator node being nulled out by abort() for incremental repa…
Browse files Browse the repository at this point in the history 
…irs.
  • Loading branch information
@adejanovski @michaelsembwever
adejanovski authored and michaelsembwever committed Aug 2, 2017
1 parent f022542 commit 74776b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/com/spotify/reaper/service/SegmentRunner.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public static void postpone(AppContext context, RepairSegment segment, Optional<
}

public static void abort(AppContext context, RepairSegment segment, JmxProxy jmxConnection) {
postpone(context, segment, Optional.fromNullable((RepairUnit) null));
postpone(context, segment, context.storage.getRepairUnit(segment.getRepairUnitId()));

This comment has been minimized.

Sign in to view

Copy link
@michaelsembwever

michaelsembwever Aug 7, 2017

Member

this will only work for incremental repairs. what about full repairs?

This comment has been minimized.

Sign in to view

Copy link
@adejanovski

adejanovski Aug 9, 2017

Author Contributor

Full repairs should have the coordinator nulled out and a new one will be picked on any new attempt. Incremental repair uses a hack that generates exactly one segment per node, so the coordinator should never change.
LOG.info("Aborting repair on segment with id {} on coordinator {}",
segment.getId(), segment.getCoordinatorHost());
jmxConnection.cancelAllRepairs();
Expand Down

0 comments on commit 74776b1

Please sign in to comment.