-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Player.enterVehicle #1965
Add Player.enterVehicle #1965
Conversation
I don't think we need a entity permission check on the vehicle. However, I'm wondering if the CanPlayerEnterVehicle hook should be checked. |
Honestly, introducing an optional player argument to Could also implement admin-only |
I think use() has the same problem in that it bypasses PlayerCanUse. Might be wrong tho |
Also, I think its preferable that enterVehicle can bypass in-engine vehicle locks |
Player.EnterVehicle already obeys CanPlayerEnterVehicle by default. It would be redundant to add an extra check. |
* enterVehicle * remove vehicle permission check * local func 3161315
Adds a function to allow forcing players into seats. This could be abusable, so it's restricted to "admin only" permissions by default, and also requires entity permissions on the player and the vehicle.