fix: Amqps function returns amqps url instead of amqp url #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Apr 2, 2024
| @@ -48,7 +48,7 @@ func (c *RabbitMQContainer) AmqpURL(ctx context.Context) (string, error) { | |||
|
|
|||
| // AmqpURL returns the URL for AMQPS clients. | |||
| func (c *RabbitMQContainer) AmqpsURL(ctx context.Context) (string, error) { | |||
| endpoint, err := c.PortEndpoint(ctx, nat.Port(DefaultAMQPPort), "") | |||
| endpoint, err := c.PortEndpoint(ctx, nat.Port(DefaultAMQPSPort), "") | |||
There was a problem hiding this comment.
I'm happy you found this wrong copy&paste mistake 🤦
|
I think this PR is colliding with #2462 but the latter include tests. I think I'll give priority to the one including tests once it passes the CI. |
Sure, I will close the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the AmqpsURL function to return an AMQPS URL instead of AMQP URL.
Why is it important?
This fix is essential as it ensures that our tests accurately reflect real-world conditions by returning the correct AMQPS URL, thereby enhancing the reliability and effectiveness of our testing environment.
Related issues