Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of DSA keys due to openssh deprecation #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeff350
Copy link

@jeff350 jeff350 commented Feb 28, 2025

Description

This is addressing issue #426 where openssh has started to disable dsa key support at compile time leading to errors in kitchen-docker stating unknown key type dsa

Issues Resolved

#426

Type of Change

Our release process assumes you are using Conventional Commit messages.

The most important prefixes you should have in mind are:

  • _fix_: which represents bug fixes, and correlates to a SemVer patch.
  • _feat_: which represents a new feature, and correlates to a SemVer minor.
  • _feat!_:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.

If you have not included a conventional commit message this can be fixed on merge.

Check List

@jeff350
Copy link
Author

jeff350 commented Feb 28, 2025

@damacus could you please review this when you have time.

Copy link
Contributor

@RulerOf RulerOf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I think that this driver should stop supporting SSH like this by default. Strip the container-modifying logic and move to the docker transport, with a separate readme detailing how to modify a container to support SSH transport.

@RulerOf
Copy link
Contributor

RulerOf commented Feb 28, 2025

@jeff350 make sure you change your commit message, something like fix: Remove use of DSA keys due to openssh deprecation, and add a sign-off at the bottom—see the other commit messages in the repo for examples.

Signed-off-by: Jeff Neel <10672501+jeff350@users.noreply.github.com>
@jeff350
Copy link
Author

jeff350 commented Mar 12, 2025

@RulerOf Thanks for taking the time to review. I have modified the commit message as you suggested.

Please let me know if there is anything I can do to help get this merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants