Add codec parameter to hdfs save command #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemhu
approved these changes
Aug 26, 2024
kortemik
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70 .
Introduced "codec" parameter to the
teragrep exec hdfs savecommand. It will take a String as the value. Parsing of that value will happen in PTH-10 and the requirements for that is documented to PTH-10 #280. The idea is to give the user the possibility to use a specific codec for the compression of saved files and PTH-10 will check if that codec is valid for the format chosen in the command.Unit tests include a general test for using all parameters together as well as a basic test for using the codec parameter.