Linked Time: Fix bug with zooming always maximizing end step #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can definitely understand wanting the function rename moved to another PR but I'm hoping it's fine. |
JamesHollyer
approved these changes
Nov 18, 2022
tensorboard/webapp/metrics/views/card_renderer/scalar_card_container.ts
Outdated
Show resolved
Hide resolved
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this pull request
Dec 19, 2022
…low#6058) ## Motivation for features / changes When changing the zoom on the scalar card with an the end fob the end fob was always placed at the maximum possible step. For Googlers b/259562961 ## Technical description of changes The `StepSelectorTimeSelection` derived by a subscription to a bunch of other Observables. The main issue was that it simply never checked if an existing end step existed. The code was also kinda hard to read(:raised_hand_with_fingers_splayed: my fault) so I went ahead with a bit of a cleanup there. ## Screenshots of UI changes Before: Zooming In:  Resetting Zoom Level:  After:  ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Navigate to http://localhost:6006?enableRangeSelection&enableDataTable 3) Place two fobs on the scalar card 4) Zoom in on a segment of the chart which contains both fobs (much easier now that tensorflow#5932 is closed) 5) Assert neither fob has moved 6) Reset the chart zoom level 7) Assert that neither fob has moved.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…low#6058) ## Motivation for features / changes When changing the zoom on the scalar card with an the end fob the end fob was always placed at the maximum possible step. For Googlers b/259562961 ## Technical description of changes The `StepSelectorTimeSelection` derived by a subscription to a bunch of other Observables. The main issue was that it simply never checked if an existing end step existed. The code was also kinda hard to read(:raised_hand_with_fingers_splayed: my fault) so I went ahead with a bit of a cleanup there. ## Screenshots of UI changes Before: Zooming In:  Resetting Zoom Level:  After:  ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Navigate to http://localhost:6006?enableRangeSelection&enableDataTable 3) Place two fobs on the scalar card 4) Zoom in on a segment of the chart which contains both fobs (much easier now that tensorflow#5932 is closed) 5) Assert neither fob has moved 6) Reset the chart zoom level 7) Assert that neither fob has moved.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…low#6058) ## Motivation for features / changes When changing the zoom on the scalar card with an the end fob the end fob was always placed at the maximum possible step. For Googlers b/259562961 ## Technical description of changes The `StepSelectorTimeSelection` derived by a subscription to a bunch of other Observables. The main issue was that it simply never checked if an existing end step existed. The code was also kinda hard to read(:raised_hand_with_fingers_splayed: my fault) so I went ahead with a bit of a cleanup there. ## Screenshots of UI changes Before: Zooming In:  Resetting Zoom Level:  After:  ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Navigate to http://localhost:6006?enableRangeSelection&enableDataTable 3) Place two fobs on the scalar card 4) Zoom in on a segment of the chart which contains both fobs (much easier now that tensorflow#5932 is closed) 5) Assert neither fob has moved 6) Reset the chart zoom level 7) Assert that neither fob has moved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
When changing the zoom on the scalar card with an the end fob the end fob was always placed at the maximum possible step.
For Googlers b/259562961
Technical description of changes
The
StepSelectorTimeSelectionderived by a subscription to a bunch of other Observables. The main issue was that it simply never checked if an existing end step existed. The code was also kinda hard to read(:raised_hand_with_fingers_splayed: my fault) so I went ahead with a bit of a cleanup there.Screenshots of UI changes
Before:
Zooming In:
Resetting Zoom Level:
After:
Detailed steps to verify changes work correctly (as executed by you)