Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttentionMechanism masking #133

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Fix AttentionMechanism masking #133

merged 1 commit into from
Apr 4, 2019

Conversation

guillaumekln
Copy link
Contributor

The scores were not masked even when memory_sequence_length was passed. Consequently, the expected mean of most tests was wrong.

@seanpmorgan seanpmorgan requested a review from qlzh727 April 3, 2019 13:15
qlzh727
qlzh727 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for fixing this issue.

@qlzh727 qlzh727 merged commit 13c4b04 into tensorflow:master Apr 4, 2019
@martin-gorner martin-gorner mentioned this pull request Dec 10, 2019
Closed
@guillaumekln guillaumekln deleted the fix-attention-mechanism-masking branch June 9, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlzh727 qlzh727 qlzh727 approved these changes

Assignees

@qlzh727 qlzh727

Labels
cla: yes seq2seq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guillaumekln @qlzh727 @googlebot @seanpmorgan @kokoro-team