Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RWMutex in MemDB #55

Closed
erikgrinaker opened this issue Mar 4, 2020 · 0 comments · Fixed by #56
Closed

Use RWMutex in MemDB #55

erikgrinaker opened this issue Mar 4, 2020 · 0 comments · Fixed by #56
Assignees
@erikgrinaker
Labels
T:breaking Type: Breaking

Comments

@erikgrinaker
Copy link
Contributor

MemDB currently uses a Mutex, but it should use an RWMutex instead. However, the mutex is returned through the public Mutex() method, so it's a breaking change. We should unexport Mutex() in #54 and then change it.
@erikgrinaker erikgrinaker added the T:breaking Type: Breaking label Mar 4, 2020
@erikgrinaker erikgrinaker self-assigned this Mar 4, 2020
@erikgrinaker erikgrinaker mentioned this issue Mar 4, 2020
Merged
faddat pushed a commit to faddat/tm-db that referenced this issue Feb 21, 2024
@thanethomson
Release v0.8.0 (tendermint#55)
1b1d8ed 
* Rename section for Go compiler update changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add link to PR for grocksdb dependency update

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Prepare v0.8.0 release in changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Build changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* go.mod: Remove unused replace directive

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Remove unnecessary coverage file

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* .gitignore: Ignore code coverage artifacts

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update release date

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
T:breaking Type: Breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

memdb: API cleanups and improvements tendermint/tm-db
1 participant
@erikgrinaker