Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement F1 farming rewards distribution PoC #100

Merged
merged 18 commits into from
Sep 10, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Sep 8, 2021

Description

closes: #91

Bullet Points

PoC (this PR)

  • Stake
  • Unstake
  • Harvest
  • Test codes

MVP(todo next PR)

  • Invariant checks
  • Documentation
  • CLI
  • gRPC query endpoints

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

hallazzang and others added 7 commits September 1, 2021 16:24
…stribution

# Conflicts:
#	proto/tendermint/farming/v1beta1/genesis.proto
#	x/farming/keeper/genesis.go
#	x/farming/keeper/invariants.go
#	x/farming/types/genesis.go
#	x/farming/types/genesis.pb.go
#	x/farming/types/params.go
#	x/farming/types/params_test.go
@dongsam dongsam requested a review from hallazzang September 8, 2021 07:58
@dongsam dongsam added the enhancement New feature or request label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #100 (2187194) into master (72748af) will decrease coverage by 1.50%.
The diff coverage is 75.18%.

❗ Current head 2187194 differs from pull request most recent head bf27b36. Consider uploading reports for the commit bf27b36 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   56.88%   55.38%   -1.51%     
==========================================
  Files          24       23       -1     
  Lines        1830     1728     -102     
==========================================
- Hits         1041      957      -84     
+ Misses        682      662      -20     
- Partials      107      109       +2     
Impacted Files Coverage Δ
x/farming/abci.go 0.00% <0.00%> (ø)
x/farming/keeper/grpc_query.go 88.57% <ø> (-1.38%) ⬇️
x/farming/keeper/keeper.go 77.77% <ø> (+4.44%) ⬆️
x/farming/simulation/decoder.go 6.66% <ø> (+1.40%) ⬆️
x/farming/types/keys.go 0.00% <0.00%> (ø)
x/farming/types/params.go 80.39% <ø> (+3.34%) ⬆️
x/farming/types/staking.go 0.00% <ø> (ø)
x/farming/keeper/epoch.go 75.00% <66.66%> (-2.78%) ⬇️
x/farming/keeper/plan.go 61.76% <66.66%> (-3.93%) ⬇️
x/farming/keeper/genesis.go 76.31% <83.33%> (+1.31%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72748af...bf27b36. Read the comment docs.

@dongsam dongsam changed the title feat: implement F1 farming rewards distribution feat: implement F1 farming rewards distribution PoC Sep 9, 2021
@hallazzang hallazzang marked this pull request as ready for review September 10, 2021 04:49
@dongsam dongsam requested a review from jaybxyz September 10, 2021 05:02
@dongsam dongsam merged commit 566057d into master Sep 10, 2021
@minkyraccoon minkyraccoon added this to the Farming F1 POC milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: F1 distribution
3 participants