chore: improve code coverage and update nil check to IsAllPositive

tendermint · Sep 24, 2021 · cb3635c · cb3635c
1 parent 806abb0
commit cb3635c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/x/farming/keeper/proposal_handler.go b/x/farming/keeper/proposal_handler.go
@@ -108,7 +108,7 @@ func (k Keeper) UpdatePublicPlanProposal(ctx sdk.Context, proposals []*types.Upd
 		if p.EpochAmount.IsAllPositive() {
 			if p.GetName() != "" {
 				if err := plan.SetName(p.GetName()); err != nil {
-					return err
+					return err // nolint:errcheck
 				}
 			}
 
@@ -151,7 +151,7 @@ func (k Keeper) UpdatePublicPlanProposal(ctx sdk.Context, proposals []*types.Upd
 			}
 
 			// change the plan to fixed amount plan if an epoch amount exists
-			if p.GetEpochAmount() != nil {
+			if p.GetEpochAmount().IsAllPositive() {
 				basePlan := types.NewBasePlan(
 					plan.GetId(),
 					plan.GetName(),
@@ -174,7 +174,7 @@ func (k Keeper) UpdatePublicPlanProposal(ctx sdk.Context, proposals []*types.Upd
 		} else if p.EpochRatio.IsPositive() {
 			if p.GetName() != "" {
 				if err := plan.SetName(p.GetName()); err != nil {
-					return err
+					return err // nolint:errcheck
 				}
 			}
 
@@ -217,7 +217,7 @@ func (k Keeper) UpdatePublicPlanProposal(ctx sdk.Context, proposals []*types.Upd
 			}
 
 			// change the plan to ratio plan if an epoch ratio exists
-			if !p.EpochRatio.IsZero() {
+			if p.EpochRatio.IsPositive() {
 				basePlan := types.NewBasePlan(
 					plan.GetId(),
 					plan.GetName(),
@@ -236,6 +236,7 @@ func (k Keeper) UpdatePublicPlanProposal(ctx sdk.Context, proposals []*types.Upd
 
 			logger := k.Logger(ctx)
 			logger.Info("updated public ratio plan", "ratio_plan", plan)
+
 		}
 	}
 

diff --git a/x/farming/types/proposal.go b/x/farming/types/proposal.go
@@ -86,6 +86,7 @@ func (p PublicPlanProposal) String() string {
 }
 
 // NewAddRequestProposal creates a new AddRequestProposal object
+// nolint:interfacer
 func NewAddRequestProposal(
 	name string,
 	farmingPoolAddr string,
@@ -140,6 +141,7 @@ func (p *AddRequestProposal) Validate() error {
 }
 
 // NewUpdateRequestProposal creates a new UpdateRequestProposal object.
+// nolint:interfacer
 func NewUpdateRequestProposal(
 	id uint64,
 	name string,
@@ -199,6 +201,7 @@ func (p *UpdateRequestProposal) Validate() error {
 }
 
 // NewDeleteRequestProposal creates a new DeleteRequestProposal object.
+// nolint:interfacer
 func NewDeleteRequestProposal(id uint64) *DeleteRequestProposal {
 	return &DeleteRequestProposal{
 		PlanId: id,