test: add more test cases for edge case

tendermint · Sep 23, 2021 · a3b073c · a3b073c
1 parent 8e71593
commit a3b073c
Showing 1 changed file with 73 additions and 23 deletions.
diff --git a/x/farming/keeper/reward_test.go b/x/farming/keeper/reward_test.go
@@ -136,29 +136,6 @@ func (suite *KeeperTestSuite) TestAllocationInfos() {
 	}
 }
 
-func (suite *KeeperTestSuite) TestAllocateRewards_AllocateAllBalances() {
-	farmingPoolAcc := simapp.AddTestAddrs(suite.app, suite.ctx, 1, sdk.ZeroInt())[0]
-	err := simapp.FundAccount(suite.app.BankKeeper, suite.ctx, farmingPoolAcc, sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)))
-	suite.Require().NoError(err)
-
-	suite.SetRatioPlan(1, farmingPoolAcc, map[string]string{
-		denom1: "0.5",
-		denom2: "0.5",
-	}, "0.5")
-	suite.SetRatioPlan(2, farmingPoolAcc, map[string]string{
-		denom1: "0.5",
-		denom2: "0.5",
-	}, "0.5")
-
-	suite.Stake(suite.addrs[0], sdk.NewCoins(sdk.NewInt64Coin(denom1, 1000000), sdk.NewInt64Coin(denom2, 1000000)))
-
-	suite.AdvanceEpoch()
-	suite.AdvanceEpoch()
-
-	rewards := suite.Rewards(suite.addrs[0])
-	suite.Require().True(coinsEq(sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)), rewards))
-}
-
 func (suite *KeeperTestSuite) TestAllocateRewards() {
 	for _, plan := range suite.sampleFixedAmtPlans {
 		_ = plan.SetStartTime(types.ParseTime("0001-01-01T00:00:00Z"))
@@ -196,6 +173,79 @@ func (suite *KeeperTestSuite) TestAllocateRewards() {
 	}
 }
 
+func (suite *KeeperTestSuite) TestAllocateRewards_FixedAmountPlanAllBalances() {
+	farmingPoolAcc := simapp.AddTestAddrs(suite.app, suite.ctx, 1, sdk.ZeroInt())[0]
+	err := simapp.FundAccount(suite.app.BankKeeper, suite.ctx, farmingPoolAcc, sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)))
+	suite.Require().NoError(err)
+
+	// The sum of epoch ratios is exactly 1.
+	suite.SetFixedAmountPlan(1, farmingPoolAcc, map[string]string{denom1: "1.0"}, map[string]int64{denom3: 600000})
+	suite.SetFixedAmountPlan(2, farmingPoolAcc, map[string]string{denom2: "1.0"}, map[string]int64{denom3: 400000})
+
+	suite.Stake(suite.addrs[0], sdk.NewCoins(sdk.NewInt64Coin(denom1, 1000000), sdk.NewInt64Coin(denom2, 1000000)))
+
+	suite.AdvanceEpoch()
+	suite.AdvanceEpoch()
+
+	rewards := suite.Rewards(suite.addrs[0])
+	suite.Require().True(coinsEq(sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)), rewards))
+}
+
+func (suite *KeeperTestSuite) TestAllocateRewards_RatioPlanAllBalances() {
+	farmingPoolAcc := simapp.AddTestAddrs(suite.app, suite.ctx, 1, sdk.ZeroInt())[0]
+	err := simapp.FundAccount(suite.app.BankKeeper, suite.ctx, farmingPoolAcc, sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)))
+	suite.Require().NoError(err)
+
+	// The sum of epoch ratios is exactly 1.
+	suite.SetRatioPlan(1, farmingPoolAcc, map[string]string{denom1: "1.0"}, "0.5")
+	suite.SetRatioPlan(2, farmingPoolAcc, map[string]string{denom2: "1.0"}, "0.5")
+
+	suite.Stake(suite.addrs[0], sdk.NewCoins(sdk.NewInt64Coin(denom1, 1000000), sdk.NewInt64Coin(denom2, 1000000)))
+
+	suite.AdvanceEpoch()
+	suite.AdvanceEpoch()
+
+	rewards := suite.Rewards(suite.addrs[0])
+	suite.Require().True(coinsEq(sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)), rewards))
+}
+
+func (suite *KeeperTestSuite) TestAllocateRewards_FixedAmountPlanOverBalances() {
+	farmingPoolAcc := simapp.AddTestAddrs(suite.app, suite.ctx, 1, sdk.ZeroInt())[0]
+	err := simapp.FundAccount(suite.app.BankKeeper, suite.ctx, farmingPoolAcc, sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)))
+	suite.Require().NoError(err)
+
+	// The sum of epoch amounts is over the balances the farming pool has,
+	// so the reward allocation should never happen.
+	suite.SetFixedAmountPlan(1, farmingPoolAcc, map[string]string{denom1: "1.0"}, map[string]int64{denom3: 700000})
+	suite.SetFixedAmountPlan(2, farmingPoolAcc, map[string]string{denom2: "1.0"}, map[string]int64{denom3: 400000})
+
+	suite.Stake(suite.addrs[0], sdk.NewCoins(sdk.NewInt64Coin(denom1, 1000000), sdk.NewInt64Coin(denom2, 1000000)))
+
+	suite.AdvanceEpoch()
+	suite.AdvanceEpoch()
+
+	rewards := suite.Rewards(suite.addrs[0])
+	suite.Require().True(rewards.IsZero())
+}
+
+func (suite *KeeperTestSuite) TestAllocateRewards_RatioPlanOverBalances() {
+	farmingPoolAcc := simapp.AddTestAddrs(suite.app, suite.ctx, 1, sdk.ZeroInt())[0]
+	err := simapp.FundAccount(suite.app.BankKeeper, suite.ctx, farmingPoolAcc, sdk.NewCoins(sdk.NewInt64Coin(denom3, 1000000)))
+	suite.Require().NoError(err)
+
+	// The sum of epoch ratios is over 1, so the reward allocation should never happen.
+	suite.SetRatioPlan(1, farmingPoolAcc, map[string]string{denom1: "1.0"}, "0.8")
+	suite.SetRatioPlan(2, farmingPoolAcc, map[string]string{denom2: "1.0"}, "0.5")
+
+	suite.Stake(suite.addrs[0], sdk.NewCoins(sdk.NewInt64Coin(denom1, 1000000), sdk.NewInt64Coin(denom2, 1000000)))
+
+	suite.AdvanceEpoch()
+	suite.AdvanceEpoch()
+
+	rewards := suite.Rewards(suite.addrs[0])
+	suite.Require().True(rewards.IsZero())
+}
+
 func (suite *KeeperTestSuite) TestOutstandingRewards() {
 	// The block time here is not important, and has chosen randomly.
 	suite.ctx = suite.ctx.WithBlockTime(types.ParseTime("2021-09-01T00:00:00Z"))