Support upsert memo #3091
Merged
Support upsert memo #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Jul 12, 2022
yycptt
reviewed
Jul 12, 2022
yycptt
reviewed
Jul 12, 2022
rodrigozhou
force-pushed
the
upsert-memo
branch
from
f8d1085 to
41f4dc4
Compare
rodrigozhou
force-pushed
the
upsert-memo
branch
7 times, most recently
from
4efc28c to
50edfaa
Compare
rodrigozhou
force-pushed
the
upsert-memo
branch
from
50edfaa to
3ef1495
Compare
alexshtin
approved these changes
Aug 24, 2022
| } | ||
|
|
||
| // check if UpsertedMemo is not nil, then it's not an empty map | ||
| if attributes.UpsertedMemo != nil && len(attributes.GetUpsertedMemo().GetFields()) == 0 { |
There was a problem hiding this comment.
This: attributes.UpsertedMemo != nil is always true here. You can remove this check.
There was a problem hiding this comment.
So, at this moment yes, but the condition above, as new attributes are added, it would become something like if attributes.UpsertedMemo == nil || attributes.something == nil || .... So, this condition here makes sense to check again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding support to upsert memo in a similar fashion as upsert search attributes.
This change depends on temporalio/api#218.
Why?
Add ability to add/update memo fields.
Feature request: temporalio/features#119
How did you test it?
Added unit tests. Tested locally and verified the values in ES document was correct.
Potential risks
No risks. This PR doesn't change any existing code, only adds new ones (minus a few minor refactors like renaming functions).
Is hotfix candidate?
No.