client: Make gRPC INTERNAL status retryable #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Jul 2, 2024
I don't think this is true. All SDKs do not consider INTERNAL retryable. |
Sushisource
approved these changes
Jul 2, 2024
|
👍 to @Quinn-With-Two-Ns - internal is not meant to be retried IIUC (except on older servers based on capability, but that was a long time ago, can probably just not retry). |
mjameswh
force-pushed
the
grpc-internal-and-ci-buildjet
branch
from
0c87dbe to
c280ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed and why?
In client, some variants of gRPC's
INTERNALstatus code are now considered as retryable (more specifically: errors where message containRST_STREAM with code 0orRST_STREAM with code 2, except TLS related issues). Users are seeing these specific errors quite regularly, apparently due to transient issues at the HTTP2 connection level. After discussion with both SDK and Server team, we believe that in most case retrying these errors would be beneficial, and in the worst case, should only result in minor waste of resource on the server.In WorkflowClient,
list().withHistories()no longer swallow client errors (they would previously result in an entry wherehistoryisundefined, with no way to know the underlying issue).