Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflow): add upsert memo command #1321

Merged
merged 6 commits into from
Jul 23, 2024
Merged

feat(workflow): add upsert memo command #1321

merged 6 commits into from
Jul 23, 2024

Conversation

tharun208
Copy link
Contributor

What was changed

Implement upsertMemo command

Why?

See temporalio/features#119

Checklist

  1. Closes [Feature Request] Add upsertMemo command #1124

  2. How was this tested:
    Added integration tests

  3. Any docs updates needed?

@tharun208 tharun208 requested a review from a team as a code owner December 18, 2023 07:06
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tharun208 tharun208 force-pushed the feat/upsert_memo_command branch from f5ea1e8 to edbc7aa Compare December 18, 2023 07:12
@tharun208 tharun208 force-pushed the feat/upsert_memo_command branch from edbc7aa to 7e4e464 Compare December 18, 2023 07:14
@bergundy
Copy link
Member

Thanks!

Overall lgtm.

Please also test deleting a memo and reading the memo from WorkflowHandle.describe, I think setting a value to null or undefined should work.

For testing, use the new style at https://github.com/temporalio/sdk-typescript/blob/main/packages/test/src/test-integration-workflows.ts

bergundy
bergundy reviewed Dec 26, 2023
View reviewed changes
packages/test/src/integration-tests-old.ts Outdated
const workflow = await client.start(workflows.upsertAndReadMemo, {
taskQueue: 'test',
workflowId: uuid4(),
args: [{ note2: 'bar' }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the newer test-integration-workflows.ts and test adding, updating and removing.

bergundy
bergundy reviewed Dec 26, 2023
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM apart from the testing part.
LMK if you need help with that.

@mjameswh
Copy link
Contributor

@tharun208 Do you want to continue working on this, or should we take it on? We'd need some more tests, as pointed out by bergundy previously.

@tharun208
Copy link
Contributor Author

tharun208 commented Jan 31, 2024 •
edited
Loading

Hi @mjameswh, I was on PTO but will look into this week

@stevensona
Copy link

Any updates here @tharun208 ?

@nhalstead
Copy link

Any update on this getting merged?

@kencrim
Copy link

kencrim commented Jul 16, 2024

Bump on the ETA for this? Would be happy to pitch in!

@tharun208
Copy link
Contributor Author

Hi, I will work on it today

@mjameswh
Copy link
Contributor

Hi, I will work on it today

@tharun208 Ah! I missed your message. I just fixed your PR.

bergundy
bergundy approved these changes Jul 16, 2024
View reviewed changes
@mjameswh mjameswh force-pushed the feat/upsert_memo_command branch from 7c901f0 to c71b52d Compare July 16, 2024 22:43
@mjameswh mjameswh merged commit ce0532f into temporalio:main Jul 23, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@mjameswh mjameswh mjameswh approved these changes

@intelligent002-rewire intelligent002-rewire intelligent002-rewire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add upsertMemo command
8 participants
@tharun208 @CLAassistant @bergundy @mjameswh @stevensona @nhalstead @kencrim @intelligent002-rewire