Allow unaltered payload response from codec #425
+50
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This change allows for codecs to return unaltered payloads, without the need to explicitly
clone them first.
Why?
It's a bit unintuitive that one can't simply return the unaltered payload, and there are a
handful of sample code snippets that do exactly this.
Checklist
Closes [Bug] Returning original unaltered payload from codec causes error #417
How was this tested:
A new codec was added to the unit tests to exercise the code with a codec that simply
returns the unaltered payload. The new unit testing will fail with existing code, but pass
with the new changes.
Any docs updates needed?
Probably not required, but if desired, the codec section could be updated to explicitly
state that it's possible to return an unaltered payload: https://docs.temporal.io/develop/dotnet/converters-and-encryption#custom-payload-codec