Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unaltered payload response from codec #425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

travismcchesney
Copy link

What was changed

This change allows for codecs to return unaltered payloads, without the need to explicitly
clone them first.

Why?

It's a bit unintuitive that one can't simply return the unaltered payload, and there are a
handful of sample code snippets that do exactly this.

Checklist

  1. Closes [Bug] Returning original unaltered payload from codec causes error #417

  2. How was this tested:
    A new codec was added to the unit tests to exercise the code with a codec that simply
    returns the unaltered payload. The new unit testing will fail with existing code, but pass
    with the new changes.

  3. Any docs updates needed?
    Probably not required, but if desired, the codec section could be updated to explicitly
    state that it's possible to return an unaltered payload: https://docs.temporal.io/develop/dotnet/converters-and-encryption#custom-payload-codec

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! May need to click that button to sign CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Returning original unaltered payload from codec causes error
3 participants