Add test #81
Closed
Add test #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LosManos
force-pushed
the
feature/add-tests
branch
from
1b3b4ab to
5f7da3a
Compare
|
I added a single test. I'm sorry for spamming your inbox with PR requests but I didn't realise the PR in my repo was connected to your repo. I had to play with the build to get test to work, until I found out tests in build was already activated. So here it is. A simple test just to get rid of the excuses not to write tests. I chose to put the test in a folder of its own. It can be argued it is over engineering. It is not visible but I tried a failing test to verify the build failed. Then I rebased and force pushed the commit into oblivion. Anything I missed? |
LosManos
force-pushed
the
feature/add-tests
branch
from
6961476 to
15b3cdb
Compare
LosManos
force-pushed
the
feature/add-tests
branch
from
15b3cdb to
c652c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test
The value of the test is small
but it is a start.