Chore/whitespace #312
Open
Chore/whitespace #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslak01
commented
Jan 15, 2025
Comment on lines
-117
to
+115
| return root, errors.New(fmt.Sprintf("trying to write a value with type `%v` to a key without depth.", key)) | ||
| return root, fmt.Errorf("trying to write a value with type `%v` to a key without depth", key) |
There was a problem hiding this comment.
This has some potential runtime implications, the change is implemented according to the lsp/linter recommendations, but I'm not sure if there was a reason for the old way it was written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains mostly nits from the stricter
gofumptgo formatter about whitespace and error formatting without initial Uppercase and ending punctuation, and a couple changes from snake_case and SCREAMING_SNAKE_CASE to camelCase as it recommends.It also has some more concise variable declaration changes, probably in part due to new syntax since the code was originally written, and some stylistic
gofumptchanges.Nothing here should affect anything in the actual running of the code (with one exception which I will make a comment about), but in my opinion it makes the code more internally consistent and easier to read as a human consumer of it.
Edit: Once committed, this PR's hash should be added to
.git-blame-ignore-revsto still show who made the original code and not hide it with formatting changes.