Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event for clearing PageFactory loop detection buffer after method end #202

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

martingrossmann
Copy link
Contributor

Description

The buffer for the PageFactory loop detection buffer was not cleared over the whole test execution. In rare cases like non-parallel dataprovider tests with only one page you have to extend the Testerra property tt.page.factory.loops.

With this change the internal buffer is cleared after the method end event. Only within a method there is a default limit of 20 when you create a page of the same type in a row.

Fixes #201

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann added this to the 1.12 milestone Jan 28, 2022
@martingrossmann martingrossmann merged commit 6631434 into master Feb 2, 2022
@martingrossmann martingrossmann deleted the fix/pagefactory-loop-detection branch February 2, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageFactory->create(...) failing after 20 calls
3 participants