Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text-field, textarea, date-picker, dropdown border error color #885

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

maomaoZH
Copy link
Collaborator

No description provided.

@maomaoZH maomaoZH requested a review from nowseemee as a code owner February 21, 2022 13:13
@maomaoZH maomaoZH requested review from felix-ico and removed request for nowseemee February 21, 2022 13:14
Copy link
Collaborator

@felix-ico felix-ico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-ico felix-ico merged commit 960e114 into refactor/semantic-tokens Feb 21, 2022
@maomaoZH
Copy link
Collaborator Author

date picker error state hover and error state focus has the same border value as error state standard based on Zeplin. I am not sure if this is intented. So I asked Joscha. Still waiting for his answer. jfyi

@felix-ico
Copy link
Collaborator

oh ok, i think there is only one value for the error state border so should be fine

@maomaoZH maomaoZH deleted the refactor/semantic-tokens-fix-mm branch February 21, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants