refactor: address FIXME:TOKEN #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acstll
requested review from
felix-ico and
maomaoZH
and removed request for
nowseemee
acstll
changed the title
felix-ico
reviewed
Feb 9, 2022
felix-ico
reviewed
Feb 9, 2022
| @@ -16,7 +16,7 @@ | |||
| --radius: var(--telekom-radius-large); | |||
| --box-shadow: var(--telekom-shadow-raised-standard); | |||
| --box-shadow-hover: var(--telekom-shadow-raised-hover); | |||
| --box-shadow-focus: 0 0 0 var(--telekom-spacing-unit-x05) | |||
| --box-shadow-focus: 0 0 0 var(--telekom-line-weight-highlight) | |||
There was a problem hiding this comment.
could this be a new token as well? seems like it's defined in the same way for a lot of components
There was a problem hiding this comment.
yep, I used this line-weight… in all borders and "focus shadows"
felix-ico
approved these changes
Feb 9, 2022
that's right, I "fixed" some in dark mode, but no all… so we'll do this QA round right after merging this 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go:
I'm leaving
FIXME:TOKENonly for those cases I believe we need to double-check with design, others I'm turning intoFIXMEbecause we can fix later, and others I'm deleting because can be addressed later, later…