Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: sets up docker compose alias for compatibility #2342

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

amir-ba
Copy link
Collaborator

@amir-ba amir-ba commented Aug 27, 2024

This PR attempts to fix the failing visual-test job in the workflow. It first removes the unneccessary ref for the actions/checkout@v3 as it tries to pull references that might not exist in addition based on the latest Docker changes the docker-compose used by our docker-chromium dependency is removed from July 2023, and we need to provide a Symlink that calls the new docker compose v2.

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit b435996
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/66cdccb6628dab0008caebbe
😎 Deploy Preview https://deploy-preview-2342--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amir-ba amir-ba added the infrastructure Repository features label Aug 27, 2024
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work! 🙂

@amir-ba amir-ba merged commit 8a694a2 into main Aug 28, 2024
12 checks passed
@amir-ba amir-ba deleted the ci/fix-visual-test branch August 28, 2024 06:56
amir-ba added a commit that referenced this pull request Sep 19, 2024
* ci: sets up docker compose alias for compatibility (#2342)

* fix: dropdown scroll fixed (#2333)

* chip accessibility fix (#2332)

* feat: chip keyboard handling fixed

* feat: chip html added

* fix: snapshot updated

* fix: focus issues fixed

* fix: readme fix

* checkbox and switch css fixes for high contrast mode (#2317)

fix: checkbox and switch CSS fixes for high contrast mode

* ghost btn in storybook  (#2341)

* fix: ghost btn in storybook fixed

* fix: one more ghost fixed

* event part in storybook fixed (#2345)

* fix: event part in storybook fixed

* fix: german versions fixed

* aria details vs aria describedby fixed for text field (#2352)

* refactor: aria details vs aria describedby fixed for text field

* fix: reverted to ariaDetailedId + description added to storybook

* chore(release): publish (#2354)

* chore(release): publish

---------

Co-authored-by: tshimber <110041439+tshimber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Repository features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants