brand header profile icon differ from default and selected version #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @niclas18, thanks for the PR! 🎉 🎉 🎉 I'll discuss this change with our designers as soon as they are back from their vacation and I'll let you know. |
|
Hello @nowseemee , |
|
Close because of #1344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profile-icon in the brand header change at OnClick. The switch use to icons named
default.svgandselected.svg. The selected one, should be only a filled onse of the default. They dont exactly the same, so you can see some bad behaviours when clicking on this icon in the header. I edited the svg so they look now exactly the same, instead of the filling.