Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip for closing modal window #771

Closed
machovan opened this issue Jan 7, 2022 · 7 comments · Fixed by #995
Closed

Tooltip for closing modal window #771

machovan opened this issue Jan 7, 2022 · 7 comments · Fixed by #995

Comments

@machovan
Copy link

machovan commented Jan 7, 2022

Hello,
I would like to ask if it is OK that tooltip for "X" to close modal window is same as Title of modal window. I expected something like "Close" instead of that.
Thank you.

@maomaoZH
Copy link
Collaborator

maomaoZH commented Jan 7, 2022

Dear @machovan,
Thanks for reaching us. If I understand it correctly, you would like to have a feature for tooltip which user can close the tooltip by clicking, eg, a close "X" button?

@machovan
Copy link
Author

machovan commented Jan 7, 2022

Dear @maomaoZH
I meant to replace text of tooltip for "X" button in modal dialog from the name of modal window to "Close" - see creen. What do you think about it?
image

@maomaoZH
Copy link
Collaborator

maomaoZH commented Jan 7, 2022

Hi @machovan thanks for your quick feedback. We will have a look and get back to you!

@mato-a
Copy link
Contributor

mato-a commented Jan 10, 2022

Hi,

This is related to: #666

Modal has prop closeButtonLabel which I think should be used for this purpose. So it is not really a feature request, but a bug.
This prop could be renamed to closeButtonAccessibilityTitle

@mato-a
Copy link
Contributor

mato-a commented Feb 23, 2022

Seems to be fixed here: v3.0.0-beta.47...v3.0.0-beta.48

We'll test it our app and get back to you.

@machovan
Copy link
Author

Currently there is no tooltip for "X" button in modal dialog. Is it OK?

@mato-a
Copy link
Contributor

mato-a commented Mar 28, 2022

So what happened is that only the related bug was fixed here: #666

But modal dialog is still missing the requested feature - to be able to set the title for close button (X).

Currently there is only closeButtonLabel which assigns aria-label to the close button.
Similar prop should be created closeButtonTitle which would assign title to the close button.

@maomaoZH maomaoZH linked a pull request Apr 13, 2022 that will close this issue
acstll pushed a commit that referenced this issue Apr 14, 2022
Co-authored-by: Maomao Meyer-Zhang <maomao.meyer-zhang@telekom.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants