Skip to content

Commit

Permalink
fix: broken release pipeline (hopefully) with (#468)
Browse files Browse the repository at this point in the history
* fix: funny Stencil-related type problem with radio-button

* refactor: update component-library-module.ts file (Angular)

* chore: do not delete yarn.lock in clean.sh script
  • Loading branch information
Arturo Castillo Delgado authored Jul 21, 2021
1 parent 117c4d7 commit b753316
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 2 deletions.
26 changes: 26 additions & 0 deletions packages/components-angular/src/component-library-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,32 @@ import {
ScaleAlert,
ScaleAppHeader,
ScaleAppShell,
ScaleBadge,
ScaleBreadcrumb,
ScaleButton,
ScaleCard,
ScaleCarousel,
ScaleChartStackCard,
ScaleCheckbox,
ScaleCollapsible,
ScaleDataGrid,
ScaleDatePicker,
ScaleDivider,
ScaleIcon,
ScaleInput,
ScaleLink,
ScaleList,
ScaleListItem,
ScaleLoadingSpinner,
ScaleMenuFlyout,
ScaleMenuFlyoutDivider,
ScaleMenuFlyoutItem,
ScaleMenuFlyoutList,
ScaleModal,
ScalePagination,
ScaleProgressBar,
ScaleRadioButton,
ScaleRatingStars,
ScaleSidebarNav,
ScaleSidebarNavCollapsible,
ScaleSidebarNavItem,
Expand All @@ -39,6 +51,7 @@ import {
ScaleTabPanel,
ScaleTable,
ScaleTag,
ScaleTextField,
ScaleToast
} from './directives/proxies';
import { TextValueAccessor } from './directives/text-value-accessor';
Expand All @@ -55,20 +68,32 @@ const DECLARATIONS = [
ScaleAlert,
ScaleAppHeader,
ScaleAppShell,
ScaleBadge,
ScaleBreadcrumb,
ScaleButton,
ScaleCard,
ScaleCarousel,
ScaleChartStackCard,
ScaleCheckbox,
ScaleCollapsible,
ScaleDataGrid,
ScaleDatePicker,
ScaleDivider,
ScaleIcon,
ScaleInput,
ScaleLink,
ScaleList,
ScaleListItem,
ScaleLoadingSpinner,
ScaleMenuFlyout,
ScaleMenuFlyoutDivider,
ScaleMenuFlyoutItem,
ScaleMenuFlyoutList,
ScaleModal,
ScalePagination,
ScaleProgressBar,
ScaleRadioButton,
ScaleRatingStars,
ScaleSidebarNav,
ScaleSidebarNavCollapsible,
ScaleSidebarNavItem,
Expand All @@ -80,6 +105,7 @@ const DECLARATIONS = [
ScaleTabPanel,
ScaleTable,
ScaleTag,
ScaleTextField,
ScaleToast,

// Value Accessors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class RadioButton {
});
}

getSiblingRadios(): HTMLScaleRadioButtonElement[] {
getSiblingRadios(): HTMLElement[] {
return Array.from(
document.querySelectorAll(`scale-radio-button[name="${this.name}"]`)
).filter(
Expand Down
3 changes: 2 additions & 1 deletion scripts/clean.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ rimraf ./packages/*/build;
rimraf ./packages/*/dist;
rimraf ./packages/docs/stencil;
rimraf ./packages/*/tsconfig.tsbuildinfo;
rimraf ./yarn.lock;
# we want to keep yarn.lock to avoid mysterious compile errors with Angular deps
# rimraf ./yarn.lock;
rimraf ./node_modules;

0 comments on commit b753316

Please sign in to comment.