Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 'Content-Length' header at callback request #203

Merged
merged 2 commits into from
Oct 22, 2013

Conversation

copitux
Copy link
Contributor

@copitux copitux commented Oct 22, 2013

On callback request rush is always sending payload (errors and complete) with full info about relayed request.

It should (regarding of rfc2616) send this header (at least)

Maybe 'Content-type':application/json should be use instead of default, but I'm not totally sure.

Node: v.0.8.26
Npm: 1.2.30
Rush 1.7.2

On callback request *rush* is always sending payload (errors and complete) with full info about relayed request.

It should (regarding of [rfc2616](http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html)) send this header (at least)

Maybe 'Content-type':application/json should be use instead of default, but I'm not totally sure.
@mrutid
Copy link
Member

mrutid commented Oct 22, 2013

Nice! it will be merged as soon as travis gives the Ok.

Thank you for contributing!

mrutid pushed a commit that referenced this pull request Oct 22, 2013
Send 'Content-Length' header at callback request (Community contrib)
@mrutid mrutid merged commit 38fe71b into telefonicaid:unstable Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants