fix 5569 pipelinerun hang on Unknown status due to duplicated task parameters

[chengjoey]

Changes

fix pipelinerun hang on Unknown status when duplicated params definded in PipelienTask

Fix #5569

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix PipelineRun hang on Unknown status when duplicated params are defined in a PipelineTask

[tekton-robot]

Hi @chengjoey. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chengjoey]

/kind bug

[dibyom]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	98.2%	98.2%	0.1

[chengjoey]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	98.2%	98.2%	0.1

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	98.2%	98.2%	0.1

[abayer]

Looks good so far - could you make these changes in pkg/apis/pipeline/v1 as well, please?

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.2%	98.3%	0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.2%	98.2%	0.1

[chengjoey]

Looks good so far - could you make these changes in pkg/apis/pipeline/v1 as well, please?

thanks for your mentions, i've made these change in pkg/apis/pipeline/v1

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.2%	98.3%	0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.2%	98.2%	0.1

[pritidesai]

So let's say I add one more param with the same name duplicate-param. It fails with:

expected exactly one, got both: [0][1].name, [0][2].name",

This is misleading, ErrMultipleOneOf might not be the best fit here. We can add a generic error saying:

params names must be unique, the same param \""+param.Name+"\" is defined multiple times at: <a list of indexes>

[chengjoey]

thanks @pritidesai , I think your suggestion is clearer to the user
i change the error to params names must be unique, the same param: duplicate-param is defined multiple times at: [0].params[1].name, [0].params[2].name
do you think this is okay

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.2%	98.3%	0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.2%	98.2%	0.1

[pritidesai]

thank you @chengjoey 👍

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [pritidesai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abayer]

/test check-pr-has-kind-label

[tekton-robot]

@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-tekton-pipeline-alpha-integration-tests
• /test pull-tekton-pipeline-build-tests
• /test pull-tekton-pipeline-integration-tests
• /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

• /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abayer]

/lgtm

[chengjoey]

/retest