Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagated parameters to beta #5540

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Propagated parameters to beta #5540

merged 1 commit into from
Oct 17, 2022

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Sep 22, 2022 •
edited
Loading

Changes

Propagated Parameters was deployed as an alpha feature in release v0.36.0. This PR promotes it to beta by removing the constraints applied under the alpha feature. This PR addresses issue #4955.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Promote propagated parameters to beta.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 22, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 22, 2022
@chitrangpatel chitrangpatel changed the title prapagating params to beta Propagated parameters to beta Sep 22, 2022
@chitrangpatel
Copy link
Contributor Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 22, 2022
@chitrangpatel
Copy link
Contributor Author

/assign @jerop

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/validate_resources.go 98.1% 98.5% 0.3

@abayer
Copy link
Contributor

abayer commented Sep 22, 2022

/hold

Holding this pending beta/stable/etc discussions in other places, such as #5530 and #5515. Probably will get covered at the API WG on Monday.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2022
jerop
jerop reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @chitrangpatel!

we need to guard the propagation behind beta feature flag in v1 - #5325

@jerop
Copy link
Member

jerop commented Sep 27, 2022

/hold cancel

we agreed to support alpha/beta/stable to unblock progress - #5325

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2022
@chitrangpatel
Copy link
Contributor Author

/hold Wait for #5593 to be merged in first. I will then propagate it all to beta

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022
@jerop jerop added this to the Pipelines v0.41 milestone Oct 12, 2022
@chitrangpatel chitrangpatel force-pushed the propagated-params-to-beta branch from cc83858 to a2fedd5 Compare October 14, 2022 20:10
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 90.4% -6.9

@chitrangpatel chitrangpatel force-pushed the propagated-params-to-beta branch from a2fedd5 to ff4f015 Compare October 14, 2022 20:43
@chitrangpatel
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2022
@chitrangpatel chitrangpatel force-pushed the propagated-params-to-beta branch from ff4f015 to 6d952c0 Compare October 17, 2022 16:32
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/validate_resources.go 98.1% 98.5% 0.3

jerop
jerop requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

believe the "extra params" change should be in a separate commit & PR

@chitrangpatel
propagating params to beta
6b6b8bd 
Propagated Parameters was deployed as an alpha feature in release v0.36.0. This PR promotes it to beta by removing the constraints applied under the alpha feature. This PR addresses issue tektoncd#4955.
@chitrangpatel chitrangpatel force-pushed the propagated-params-to-beta branch from 6d952c0 to 6b6b8bd Compare October 17, 2022 17:01
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/validate_resources.go 98.1% 98.5% 0.3

jerop
jerop approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chitrangpatel!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@jerop jerop mentioned this pull request Oct 17, 2022
Closed
4 tasks
@abayer
Copy link
Contributor

abayer commented Oct 17, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@tekton-robot tekton-robot merged commit 2b54123 into tektoncd:main Oct 17, 2022
@JeromeJu JeromeJu mentioned this pull request Oct 19, 2022
Closed
@JeromeJu JeromeJu mentioned this pull request Nov 9, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@JeromeJu JeromeJu JeromeJu left review comments

@afrittoli afrittoli Awaiting requested review from afrittoli

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@abayer abayer

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.41
Development

Successfully merging this pull request may close these issues.
5 participants
@chitrangpatel @tekton-robot @abayer @jerop @JeromeJu