Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump knative.dev/pkg vendoring. Use klog/v2 #4538

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Bump knative.dev/pkg vendoring. Use klog/v2 #4538

merged 1 commit into from
Feb 1, 2022

Conversation

guillaumerose
Copy link
Contributor

@guillaumerose guillaumerose commented Feb 1, 2022 •
edited
Loading

Changes

Kubernetes vendoring is using klog v2 but knative is using v1.
When knative configure the logging, it doesn't configure the underlying
kubernetes logging.

Related to tektoncd/triggers#1301

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Flags used by Kubernetes logging system are now working

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 1, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2022
@guillaumerose
Bump knative.dev/pkg vendoring. Use klog/v2
41eb4b5 
Kubernetes vendoring is using klog v2 but knative is using v1.
When knative configure the logging, it doesn't configure the underlying
kubernetes logging.
vdemeester
vdemeester approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @tektoncd/core-maintainers

@tekton-robot tekton-robot requested a review from a team February 1, 2022 15:42
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
imjasonh
imjasonh reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2022
@tekton-robot tekton-robot merged commit 05baf08 into tektoncd:main Feb 1, 2022
@mattmoor
Copy link
Member

I was about to bump y'all to knative's 1.2, but I found this.

Not called out in the release notes here is an update to the Kubernetes minimum version. Just wanted to give you a heads up on that.

@afrittoli
Copy link
Member

I was about to bump y'all to knative's 1.2, but I found this.

Not called out in the release notes here is an update to the Kubernetes minimum version. Just wanted to give you a heads up on that.

Thanks @mattmoor - I will update the release notes accordingly.

jerop added a commit to jerop/pipeline that referenced this pull request Mar 29, 2022
@jerop
Document that k8s 1.21 is the minimum required
cec8dd2 
Since v0.33 release, Tekton Pipelines requires Kubernetes 1.21.

This updates all references of Kubernetes 1.20 as necessary,
including the command for setting up K8s cluster.

Release: https://github.com/tektoncd/pipeline/releases/tag/v0.33.0.

PR with bump: tektoncd#4538.
@jerop jerop mentioned this pull request Mar 29, 2022
Merged
5 tasks
tekton-robot pushed a commit that referenced this pull request Mar 30, 2022
@jerop @tekton-robot
Document that k8s 1.21 is the minimum required
f05da78 
Since v0.33 release, Tekton Pipelines requires Kubernetes 1.21.

This updates all references of Kubernetes 1.20 as necessary,
including the command for setting up K8s cluster.

Release: https://github.com/tektoncd/pipeline/releases/tag/v0.33.0.

PR with bump: #4538.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh left review comments

@vdemeester vdemeester vdemeester approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guillaumerose @tekton-robot @mattmoor @afrittoli @vdemeester @imjasonh