Remove mention of ssh-keygen from auth doc #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auth docs mention that tekton generates a known_hosts file using ssh-keygen but this isn't quite right - we used to fetch the key using ssh-keyscan but now accept it by updating git's core.sshCommand. This PR updates the auth doc to describe the implementation we use to populate known_hosts when its missing.
tekton-robot
added
release-note
|
/kind documentation |
tekton-robot
added
the
kind/documentation
|
This looks great, thanks @sbwsg for a quick response 👍 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The auth docs mention that tekton generates a known_hosts file using
ssh-keygen but this isn't quite right - we used to fetch the key
using ssh-keyscan but now accept it by updating git's core.sshCommand.
This PR updates the auth doc to describe the implementation we use to
populate known_hosts when its missing.
Submitter Checklist
Release Notes