fixes 2978, missing command in monitoring steps #2990
Conversation
|
@psschwei: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
kind/documentation
tekton-robot
added
the
size/XS
|
/release-note-none |
tekton-robot
added
release-note-none
docs/taskruns.md
Outdated
| @@ -334,6 +334,10 @@ If multiple `Steps` are defined in the `Task` invoked by the `TaskRun`, you can | |||
| status in the `steps.results` field using the following command, where `<name>` is the name of the target | |||
There was a problem hiding this comment.
thanks @psschwei
since we are changing this section, can I please ask you to correct one more thing? 🙏
please replace steps.results with status.steps.
Tekton stores status under status.steps:
status:
steps:
- container:
imageID:
name:
terminated:
containerID:
exitCode:
psschwei
force-pushed
the
missing-monitoring-step
branch
from
dbf525d to
c7d522c
Compare
|
/approve @vdemeester how do address this? Do we go back and update the doc in the release branch? This issue (#2978) was opened for 0.14.1 release. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
@pritidesai we could cherry-pick it in the release-0.14.x branch but the tagged documentation is immutable so… 😓 |
lets leave it as is, we can refer back to master if needed |
vdemeester
added
kind/documentation
Changes
This fixes #2978 , adding the missing command to the docs.
Should this be backported to 0.14.1 and 0.14.2 ?
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
/kind documentation
/release-note-none