Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using PATCH to update labels/annotations #2907

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Stop using PATCH to update labels/annotations #2907

merged 1 commit into from
Jul 7, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Jul 6, 2020

Changes

Stop using PATCH for label/annotation updates. This mimics a similar change to the pipelinerun controller, which I wasn't force to make when I updated taskrun to // +genreconciler because of #2728.

cc @R2wenD2 @afrittoli @vdemeester @imjasonh

@tekton-robot
Copy link
Collaborator

@mattmoor: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 6, 2020
@tekton-robot tekton-robot requested review from afrittoli and dlorenc July 6, 2020 21:06
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 76.3% 76.5% 0.3

@mattmoor
Copy link
Member Author

mattmoor commented Jul 6, 2020

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 6, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Jul 6, 2020

/retest

This doesn't repro for me locally, so going to retest while I take a deeper look.

@mattmoor mattmoor closed this Jul 6, 2020
@mattmoor mattmoor reopened this Jul 6, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 76.3% 76.5% 0.3

@mattmoor
Copy link
Member Author

mattmoor commented Jul 6, 2020

/retest

@mattmoor
Copy link
Member Author

mattmoor commented Jul 7, 2020

@vdemeester how do I kick the kind label bot? 🤣

@mattmoor
Copy link
Member Author

mattmoor commented Jul 7, 2020

/assign @vdemeester @afrittoli

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@vdemeester
Copy link
Member

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 7, 2020
vdemeester
vdemeester reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
afrittoli
afrittoli reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think it would be nice to have an item in our backlog about this, i.e. using patch again and enhance our test lib accordingly.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 3243489 into tektoncd:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@afrittoli afrittoli afrittoli left review comments

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@vdemeester vdemeester

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattmoor @tekton-robot @vdemeester @afrittoli